-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mark flaky tests #3319
mark flaky tests #3319
Conversation
86dd108
to
e85d9be
Compare
Thanks for working on this! I had to manually restart jobs quite often lately due to flaky tests that aren't marked yet (but have an open issue). |
[deleted] |
It surprises me that so many checks have failed for this PR. The logs are expired, can you re-run the tests? |
This PR only marks the flaky tests for JUnit to execute them multiple times so we don't have to do that manually, but we should still fix the tests to be reliable so we don't need that at all. So, the issues should stay open until we have improved the tests themselves. See also the description in TESTING.md |
e85d9be
to
0231e93
Compare
I just rebased this on @farodin91: I'd like to get this merged soon as the flaky tests are really a pain. I have to restart jobs all the time which especially slows down merging of Dependabot PRs. |
0231e93
to
ca60396
Compare
janusgraph-hbase/src/test/java/org/janusgraph/graphdb/hbase/HBaseOperationCountingTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jan Jansen <[email protected]>
ca60396
to
7b3125d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now ready for review. The changes were done by @farodin91. I only updated the branch and removed the annotation of one test which doesn't look flaky to me and where the annotation apparently didn't really work because the test isn't suitable to be executed repeatedly.
Merging via lazy consensus |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Thank you for contributing to JanusGraph!
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
master
)?For code changes:
For documentation related changes: