Skip to content

Commit

Permalink
Remove minSuccess arguments from remaining tests
Browse files Browse the repository at this point in the history 
Follow-up to #3961 where I forgot to remove this argument from these 2
tests because they are using `ParameterizedRepeatedIfExceptionsTest`
instead of `RepeatedIfExceptionsTest`.

Signed-off-by: Florian Hockmann <[email protected]>
  • Loading branch information
@FlorianHockmann
FlorianHockmann committed Sep 14, 2023
1 parent 2ba933c commit cbb1f9c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions janusgraph-cql/src/test/java/org/janusgraph/graphdb/cql/CQLGraphCacheTest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,15 +45,15 @@ public void testIndexUpdatesWithReindexAndRemove() throws InterruptedException,
}

// flaky test: https://github.com/JanusGraph/janusgraph/issues/1457
@ParameterizedRepeatedIfExceptionsTest(repeats = 4, minSuccess = 2)
@ParameterizedRepeatedIfExceptionsTest(repeats = 3)
@ValueSource(booleans = {true, false})
@Override
public void simpleLogTest(boolean useStringId) throws InterruptedException {
super.simpleLogTest(useStringId);
}

// flaky test: https://github.com/JanusGraph/janusgraph/issues/1457
@ParameterizedRepeatedIfExceptionsTest(repeats = 4, minSuccess = 2)
@ParameterizedRepeatedIfExceptionsTest(repeats = 3)
@ValueSource(booleans = {true, false})
@Override
public void simpleLogTestWithFailure(boolean useStringId) throws InterruptedException {
Expand Down
4 changes: 2 additions & 2 deletions janusgraph-cql/src/test/java/org/janusgraph/graphdb/cql/CQLGraphTest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -229,15 +229,15 @@ public void testHasTTL() {
}

// flaky test: https://github.com/JanusGraph/janusgraph/issues/1457
@ParameterizedRepeatedIfExceptionsTest(repeats = 4, minSuccess = 2)
@ParameterizedRepeatedIfExceptionsTest(repeats = 3)
@ValueSource(booleans = {true, false})
@Override
public void simpleLogTest(boolean useStringId) throws InterruptedException {
super.simpleLogTest(useStringId);
}

// flaky test: https://github.com/JanusGraph/janusgraph/issues/1457
@ParameterizedRepeatedIfExceptionsTest(repeats = 4, minSuccess = 2)
@ParameterizedRepeatedIfExceptionsTest(repeats = 3)
@ValueSource(booleans = {true, false})
@Override
public void simpleLogTestWithFailure(boolean useStringId) throws InterruptedException {
Expand Down

1 comment on commit cbb1f9c

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: cbb1f9c Previous: 6205752 Ratio
org.janusgraph.JanusGraphSpeedBenchmark.basicAddAndDelete 15058.144725912047 ms/op 22579.688640648168 ms/op 0.67
org.janusgraph.GraphCentricQueryBenchmark.getVertices 1395.057213858238 ms/op 1693.3271383287579 ms/op 0.82
org.janusgraph.MgmtOlapJobBenchmark.runClearIndex 221.91360388695654 ms/op 222.8017045478261 ms/op 1.00
org.janusgraph.MgmtOlapJobBenchmark.runReindex 470.0705134715152 ms/op 565.8578123657144 ms/op 0.83
org.janusgraph.JanusGraphSpeedBenchmark.basicCount 434.41770734546213 ms/op 458.33261599744327 ms/op 0.95
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.getValuesAllPropertiesWithAllMultiQuerySlicesUnderMaxRequestsPerConnection 9392.61179319931 ms/op 13027.779634965924 ms/op 0.72
org.janusgraph.CQLMultiQueryBenchmark.getElementsWithUsingEmitRepeatSteps 34065.37493558571 ms/op 42947.178598 ms/op 0.79
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.getValuesMultiplePropertiesWithSmallBatch 35041.43563281666 ms/op 47549.632632216664 ms/op 0.74
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.vertexCentricPropertiesFetching 71597.29867973333 ms/op 99834.0656897 ms/op 0.72
org.janusgraph.CQLMultiQueryBenchmark.getAllElementsTraversedFromOuterVertex 17286.937061706743 ms/op 21717.084192162452 ms/op 0.80
org.janusgraph.CQLMultiQueryBenchmark.getVerticesWithDoubleUnion 614.2853281236818 ms/op 763.9341528866134 ms/op 0.80
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.getValuesAllPropertiesWithUnlimitedBatch 8948.319496036343 ms/op 12156.922564930786 ms/op 0.74
org.janusgraph.CQLMultiQueryBenchmark.getNames 16581.8349982331 ms/op 21623.489783162986 ms/op 0.77
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.getValuesThreePropertiesWithAllMultiQuerySlicesUnderMaxRequestsPerConnection 11491.6333347575 ms/op 16175.502236128377 ms/op 0.71
org.janusgraph.CQLMultiQueryBenchmark.getLabels 15006.017321281886 ms/op
org.janusgraph.CQLMultiQueryBenchmark.getVerticesFilteredByAndStep 656.8553007568424 ms/op 828.1404002420064 ms/op 0.79
org.janusgraph.CQLMultiQueryBenchmark.getVerticesFromMultiNestedRepeatStepStartingFromSingleVertex 23345.486950311366 ms/op 28624.24182517619 ms/op 0.82
org.janusgraph.CQLMultiQueryBenchmark.getVerticesWithCoalesceUsage 593.4739214320581 ms/op 770.5690844916234 ms/op 0.77
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.getValuesMultiplePropertiesWithAllMultiQuerySlicesUnderMaxRequestsPerConnection 30992.84298869055 ms/op 42753.61769863095 ms/op 0.72
org.janusgraph.CQLMultiQueryBenchmark.getIdToOutVerticesProjection 407.13633731657404 ms/op 518.0698862502832 ms/op 0.79
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.getValuesMultiplePropertiesWithUnlimitedBatch 35294.82768357109 ms/op 45390.244630558336 ms/op 0.78
org.janusgraph.CQLMultiQueryBenchmark.getNeighborNames 16759.86944721487 ms/op 21751.645129234243 ms/op 0.77
org.janusgraph.CQLMultiQueryBenchmark.getElementsWithUsingRepeatUntilSteps 18249.355607405716 ms/op 22817.45437812944 ms/op 0.80
org.janusgraph.CQLMultiQueryBenchmark.getAdjacentVerticesLocalCounts 17308.04890827897 ms/op 21574.947662841663 ms/op 0.80

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.