Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JanusGraph.Net 1.0.0 Release #155

Merged
merged 3 commits into from
Nov 15, 2023
Merged

JanusGraph.Net 1.0.0 Release #155

merged 3 commits into from
Nov 15, 2023

Conversation

FlorianHockmann
Copy link
Member

This makes JanusGraph.Net compatible with the JanusGraph 1.0.0 release. Some changes were needed compared to the pre-release versions of 1.0.0:

  • Update Gremlin.Net to 3.7.0 (JanusGraph 1.0.0 also uses TinkerPop 3.7.0)
  • Add nullable annotations (were added in Gremlin.Net 3.7.0)
  • Support string type custom vertex IDs: Required some changes to RelationIdentifier and RelationIdentifierSerializer which are backwards incompatible for GraphBinary, just like in JanusGraph 1.0.0.

Note that JanusGraph.Net still only supports - as the delimiter character for RelationIdentifier. JanusGraph offers a property to change to a different character which allows users to use - as a character within vertex IDs, e.g., to use UUIDs.
I think this is a feature which we can still add to JanusGraph.Net at a later point. I'll create an issue for this when merging this PR.

@FlorianHockmann FlorianHockmann force-pushed the janusgraph-1.0.0 branch 2 times, most recently from 387361d to ad67a0f Compare November 1, 2023 12:43
README.md Outdated
Since JanusGraph 1.0.0 is not officially released yet, we also only have prerelease versions of JanusGraph.Net.
Note that serialization of Geoshapes via GraphBinary is only compatible with JanusGraph 1.0.0 and higher.
GraphBinary serialization includes breaking changes in version 1.0.0.
JanusGraph.Net 1.0 is therefore ony compatible with JanusGraph 0.6 if GraphSON
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Signed-off-by: Florian Hockmann <[email protected]>
Signed-off-by: Florian Hockmann <[email protected]>
This release is compatible with JanusGraph 1.0.0.

Notable changes:
* Gremlin.Net bumped to version 3.7.0.
* Support for string vertex IDs.
* Nullable annotations.
* **Breaking**: Support for JanusGraph versions < 1.0.0 is dropped for
GraphBinary. Support for versions older than 0.6.0 is also dropped for
GraphSON.

This release bumps Gremlin.Net to version 3.7.0 a

Signed-off-by: Florian Hockmann <[email protected]>
@FlorianHockmann
Copy link
Member Author

@farodin91 Do you want to review this again or can I merge?

Copy link
Contributor

@farodin91 farodin91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FlorianHockmann FlorianHockmann merged commit b89ff1d into master Nov 15, 2023
8 of 9 checks passed
@FlorianHockmann FlorianHockmann deleted the janusgraph-1.0.0 branch November 15, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants