-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CascadiaCode-2407.24 #5996
Comments
@720720 that's incorrect. There are two entries, the NF version and the official one being this one. By request of our user base. I'm adding a switch that allows to specify |
https://github.com/microsoft/cascadia-code#font-formats There are two Cascadia Code ttf variants: ttf variable and ttf static. The font installer is very convenient but it allows you to install fonts twice. |
@720720 the problem with that switch is that Fonts aren't versioned. So you can update the font rather easily, in this case, oh-my-posh will always replace it. |
https://www.jordanmalcolm.com/deploying-windows-10-fonts-at-scale/ Windows 10 Version 1809 and higher allows you to install a font at least 4 times if you just copy the font and set a registry entry. ttf, otf, %windir%\Fonts, %LOCALAPPDATA%\Microsoft\Windows\Fonts This might lead to improper font rendering. |
@720720 that blog post doesn't state that, where did you get this information from? Nobody has ever reported that, nor have I ever seen this become unstable and I install the font over and over again when testing. |
https://github.com/microsoft/cascadia-code#installation
Image 2 shows 8 font faces, the font is now installed 2 times, i could repeat that with otf and have 4 installations of the same font. The Windows font installer gives you a warning if a font is already installed. |
@720720 that comment is one that says "can", never trust comments like that IMHO. I'll check where it gets that information from because on file level, I don't see these being added additionally. |
@JanDeDobbeleer the new release https://github.com/JanDeDobbeleer/oh-my-posh/releases/tag/v24.13.0 has no assets |
@720720 aware of that, a GitHub action step we use has a broken update |
@720720 fixed |
@720720 the last issue of duplicate entries is now also fixed. |
@JanDeDobbeleer thanks for your work, but i think there are some issues left. |
Administrator and User can still install fonts to |
Nerd Fonts 3.3.0: 68 fonts total, 55 fonts ttf, 13 fonts otf
https://ohmyposh.dev/docs/installation/fonts
There is no nerd font that comes in ttf and otf format at the moment. |
|
%LOCALAPPDATA%\Microsoft\Windows\Fonts
https://github.com/microsoft/cascadia-code#installation
oh-my-posh font install --ttf select CascadiaCode-2407.24 as user installs 6 of 12 ttf variable and 66 of 72 ttf static fonts to %LOCALAPPDATA%\Microsoft\Windows\Fonts most users probably want variable fonts but in no way an incomplete combination of variable and static fonts |
@720720 I can't solve unavailable fonts. About the first one, yes, that's by design. The replacement logic only works for the same context (user or system). As a user you can't access the admin registry nor font location anyways, so it's uninstall as user/system and install as user/system. |
@JanDeDobbeleer I think the Cascadia Code ttf variable and static font installation is a problem. |
@720720 Yeah but that's a new requirement. That wasn't something I was aware off. |
@JanDeDobbeleer I came across the problem last week when writing a simple powershell script to install Cascadia Code. |
@JanDeDobbeleer from a usability point of view it would be nice to choose the Cascadia Code font variant in the font selector.
|
@720720 that's also an option. But a little more work. I already regret adding this font option which on its own was already a hack. |
I also regret trying to write that powershell script. |
@JanDeDobbeleer https://ohmyposh.dev/docs/installation/fonts
The CascadiaCode-2407.24 ttf folder contains the ttf variable fonts and a static subfolder. The first two variants are inconvenient, you might consider #5996 (comment) since CascadiaCode-2407.24 is already a hack.
Cascadia Code is misleading since only CascadiaCode-2407.24 and not the Cascadia Code Nerd Font is affected. |
@720720 valid point, I didn't take that into account. The problem is that there' no good folder support when dealing with zip files. I'll fix that bug! |
@JanDeDobbeleer thanks for the update
|
Seems to download CascadiaCode-2407.24 before it does the error check. |
Theres a mismatch between CascadiaCode (MS) in the Docs and CascadiaCode-2407.24 in the font selection menu. I think for users it would be way easier to just select the font in the menu.
@JanDeDobbeleer CascadiaCode-2407.24 is still hardcoded anyway. |
@720720 true but there's a difference in what's hardcoded and how dynamic it can be. |
@JanDeDobbeleer the font installer can't work without hardcoding as long as you mix Nerd Fonts and CascadiaCode-2407.24. This is why I would solve the problem via the font selector. Command line parameters scare average users that just want to install a font quickly. And the error message that you get for the CascadiaCode-2407.24 installation via menu is an unexpected behaviour. |
@720720 A combination of both would work though. I agree on the accessibility part. Something for tomorrow.
That's because of caching. |
@JanDeDobbeleer thanks, the cache is really smart. |
https://en.wikipedia.org/wiki/Web_Open_Font_Format
The Web Open Font Format (WOFF) is a font format for use in web pages. @JanDeDobbeleer you cannot install woff fonts in Windows. |
The Windows installer detects that otf static is installed and replaces it with ttf static. The Oh-My-Posh installer does not check if a font is already installed. The otf fonts are still in the fonts directory but users cannot uninstall the fonts via windows settings any longer. |
The Windows installer does not detect that CascadiaCode ttf variable contains several fonts. The Oh-My-Posh installer does not check if a font is already installed. The result is a broken font installation in both cases. |
@720720 can you explain those last sentences like I'm 5? Why is that broken? I thought I did remove the fonts which were there previously, but can double check on that. Maybe it's an idea to explicitly list what you expect to happen in each case. |
WOFF2 fonts are for web use only, you cannot install them on any OS. @JanDeDobbeleer I think you should remove them from the font selection menu. |
@JanDeDobbeleer Im working on a better description for |
@720720 but is this the only thing to fix then?
I'm not going to write a replacement for Windows font installation, that's a bridge too far IMHO. So if more obscure information fetching is needed (these are terrible win32 API's), I'm just removing this font from the menu entirely. |
DESCRIPTION@JanDeDobbeleer #5996 (comment)
The font installer lists all CascadiaCode font formats. TEST1. Install CascadiaCode otf staticCascadiaCodeNF-Bold.otf
2. Install CascadiaCode ttf variableCascadiaCodeNF.ttf
EXPECTED RESULTCascadiaCodeNF.ttf contains 6 fonts: Cascadia Code NF Regular The installer detects that CascadiaCodeNF.ttf contains 6 fonts.
ACTUAL RESULTThe installer does not detect that CascadiaCodeNF.ttf contains 6 fonts.
The result is a font installation of 6 ttf variable and 5 otf static fonts. CONCLUSIONWindows and Oh-My-Posh font installers cannot handle the replacement of static by variable fonts in a sane way. SOLUTIONS1. Remove the CascadiaCode static font variants from the font installerhttps://github.com/microsoft/cascadia-code#installation The ttf variable font is recommended for all users. 2. Remove CascadiaCode from the font installer when a winget package is availablemicrosoft/cascadia-code#283 Winget will support fonts at some point. 3. Improve the font installerhttps://github.com/Crosse/font-install The font installer has no functional uninstaller. |
@720720 I will only allow the installation of |
@JanDeDobbeleer thank you. |
Code of Conduct
What would you like to see changed?
oh-my-posh font install CascadiaCode-2407.24
as regular user installs all Cascadia Code otf static fonts to the users font directory.There are several problems with this approach:
Windows 11 Pro comes with Windows Terminal 1.21.3231.0 preinstalled that bundles:
CascadiaCode.ttf
CascadiaCodeItalic.ttf
CascadiaMono.ttf
CascadiaMonoItalic.ttf
so you end up with a duplicate installation of these fonts.
For Windows or any OS that employs TrueType hinting the ttf variable variant of Cascadia Code would be a better choice.
Reading the Oh My Posh Fonts documentation a user expects to install Cascadia Code Nerd Font and not:
Cascadia Code
Cascadia Code NF
Cascadia Code PL
Cascadia Mono
Cascadia Mono NF
Cascadia Mono PL
CascadiaCode-2407.24 should just install the ttf variable variant of Cascadia Code NF:
CascadiaCodeNF.ttf
CascadiaCodeNFItalic.ttf
CascadiaMonoNF.ttf
CascadiaMonoNFItalic.ttf
The text was updated successfully, but these errors were encountered: