Call getArgs only once

Jan0707 · Nov 1, 2021 · 228187d · 228187d
1 parent 2e0fe96
commit 228187d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/Type/ObjectProphecy/WillExtendOrImplementDynamicReturnTypeExtension.php b/src/Type/ObjectProphecy/WillExtendOrImplementDynamicReturnTypeExtension.php
@@ -62,11 +62,13 @@ public function getTypeFromMethodCall(
             return $returnType;
         }
 
-        if (0 === \count($methodCall->getArgs())) {
+        $args = $methodCall->getArgs();
+
+        if (0 === \count($args)) {
             return $returnType;
         }
 
-        $argumentType = $scope->getType($methodCall->getArgs()[0]->value);
+        $argumentType = $scope->getType($args[0]->value);
 
         if (!$argumentType instanceof Type\Constant\ConstantStringType) {
             return $returnType;

diff --git a/src/Type/Prophet/ProphesizeDynamicReturnTypeExtension.php b/src/Type/Prophet/ProphesizeDynamicReturnTypeExtension.php
@@ -50,15 +50,16 @@ public function getTypeFromMethodCall(
         $parametersAcceptor = Reflection\ParametersAcceptorSelector::selectSingle($methodReflection->getVariants());
 
         $returnType = $parametersAcceptor->getReturnType();
+        $args = $methodCall->getArgs();
 
-        if (0 === \count($methodCall->getArgs())) {
+        if (0 === \count($args)) {
             return new Type\Generic\GenericObjectType(
                 Prophecy\ObjectProphecy::class,
                 []
             );
         }
 
-        $argumentType = $scope->getType($methodCall->getArgs()[0]->value);
+        $argumentType = $scope->getType($args[0]->value);
 
         if (!$argumentType instanceof Type\Constant\ConstantStringType) {
             return $returnType;