forked from iliaal/php_excel
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3 8 6 #11
Open
do-io
wants to merge
94
commits into
Jan-E:master
Choose a base branch
from
doPhp:v3_8_6
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
V3 8 6 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h> with <space><backslash> in pre-compiler definitions
…ks for older LibXL versions and older PHP versions
PHP7 requires the zend_object in the backing structs to come last which is also reflected by the various fetch_object functions that all subtract from the zend_object pointer.
fix a multitude of segfaults
if you license libxl with source code and build your own copy, then it won't export the xlBookSetKey symbol. Detect this and don't call the function in that case.
this fixes the tests failing for people who use libxl licensed with source code. This also adds a static method `requiresKey` to ExcelBook in order to check whether a license key is required or not
…redentials in README
Coredump fix when passing valid user name/key with constructor
Fix iliaal#241 for PHP7
Fix iliaal#234 for PHP7
added new methods Book::getSheetName() and Book::loadInfo()
update ignore
git ignore update
Readme update
Signed-off-by: Darren Odden <[email protected]>
Update README.md
Signed-off-by: Darren Odden <[email protected]>
Update README.md
current test in 029.phpt
update to point to main branch
* Create CODE_OF_CONDUCT.md Signed-off-by: Darren Odden <[email protected]> * Create LICENSE.md Signed-off-by: Darren Odden <[email protected]> * basic files uploaded Signed-off-by: Darren Odden <[email protected]> * Update CONTRIBUTING.md Signed-off-by: Darren Odden <[email protected]> --------- Signed-off-by: Darren Odden <[email protected]>
Signed-off-by: Darren Odden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.