Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve isBanned messaging #77

Closed
JamieMason opened this issue May 30, 2022 · 1 comment
Closed

Improve isBanned messaging #77

JamieMason opened this issue May 30, 2022 · 1 comment
Labels
Type: Feat

Comments

@JamieMason
Copy link
Owner

JamieMason commented May 30, 2022 •
edited
Loading

Description

Make messaging clearer when an instance of a dependency matches versionGroup.isBanned.

Current output is like so:

x  react remove this dependency

Suggested Solution

From #65 (comment):

I would just change the error to be something more useful. I think it would be nice to say react is ban from use within the code base and then in the config isBanned can take a reason that we can customize and surface to the user so we can say "go to this url to learn more why"
JamieMason added a commit that referenced this issue Jun 4, 2022
@JamieMason
feat(list-mismatches): display reasons for mismatches
3bdab44 
Refs #65
Refs #77
Closes #79
JamieMason added a commit that referenced this issue Jun 4, 2022
@JamieMason
feat(list-mismatches): show reason for mismatches
81160b5 
Refs #65
Refs #77
Closes #79
JamieMason added a commit that referenced this issue Jun 25, 2022
@JamieMason
feat(output): better explain mismatch reasons
45e0cf1 
Refs #65
Refs #77
Closes #79
@JamieMason
Copy link
Owner Author

Proposed fix released in 8.2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Feat
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JamieMason