remove: deps.ts & change: don't use Deno enabled workers #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itohatweb
changed the title
|
Sorry to take so long to get around to this @itohatweb but this all looks good to me. I saw it when it was first raised and completely forgot to get back to it. Are you able to change the CI to not test against the earlier version of Deno (where this change doesn't work) and add a note to the repo for older versions of Deno to use an older version of this? Then should be ready to merge after the checks pass. Thanks for your contribution! |
|
All tests should pass now. |
|
Perfect, thanks for the changes. I'll release an updated version now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove: deps.ts
change: remove the use of the unstable Deno workers since they are not necessary