Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pdf viewer in code server #3639

Merged
merged 6 commits into from
Jan 23, 2023

Conversation

modaresimr
Copy link
Contributor

For resolving pdf viewer in LatexWorkshop, i have first edited the source codes for serving relative path for in viewer.
Then, I change the URL for opening the pdf viewer by helping from asExternal. Using asExternal causes removing the path part, so I add the path part to the result of asExternal for showing pdf files.

It works fine.

@James-Yu James-Yu requested review from James-Yu and removed request for James-Yu January 11, 2023 04:48
@James-Yu James-Yu self-assigned this Jan 19, 2023
@James-Yu James-Yu merged commit c4c37f8 into James-Yu:master Jan 23, 2023
@James-Yu James-Yu mentioned this pull request Feb 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants