Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No PDF refresh on code-server after update 10.0.0 #4306

Closed
wasalm opened this issue Jul 1, 2024 · 0 comments · Fixed by #4307
Closed

No PDF refresh on code-server after update 10.0.0 #4306

wasalm opened this issue Jul 1, 2024 · 0 comments · Fixed by #4307

Comments

@wasalm
Copy link
Contributor

wasalm commented Jul 1, 2024

After the update of 10.0.0, the build in pdf viewer does not refresh after building, when running LaTeX-Workshop in code-server.

The issue originates from the the viewer/components/refresh.ts line 79.
Namely, this file retrieves the new path and updates the viewer.
As you may see it uses an absolute path for the pdf.
This interferes with the proxy system of code-server, which prefixes different ports by /proxy/{RANDOM_PORT_NUMBER}. Hence, the pdf cannot be loaded as it receives an 404 error.

When removing the leading slash in line 79, the issue would be fixed.

James-Yu pushed a commit that referenced this issue Jul 1, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant