This repository has been archived by the owner on Jul 1, 2023. It is now read-only.
Fixed files skipping based on version_compare() in Windows #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a strange bug in Windows when using
version_compare()
. The previous code!version_compare(PHP_VERSION, $m[2], $m[1])
doesn't return expected values. However the strict comparison=== false
works.I added the strict comparison and simplified the code a little.