Skip to content
This repository has been archived by the owner on Jul 1, 2023. It is now read-only.

Added option --version #72

Merged
merged 1 commit into from
Jul 10, 2016
Merged

Added option --version #72

merged 1 commit into from
Jul 10, 2016

Conversation

o5
Copy link
Contributor

@o5 o5 commented Jun 7, 2016

Closes #71.

@grogy
Copy link
Contributor

grogy commented Jun 8, 2016

Hello,

thanks for your idea and first version of PR. 👍

Nice - this works, but...:

  • File parallel-lint.php is base file for tool. It is not good place for show versions.
  • Source of code has class Settings [1]. I mean it is better place for check input parameters.
  • Maybe is in source better place where is possible define and run function showVersion.

[1] https://github.com/JakubOnderka/PHP-Parallel-Lint/blob/master/src/Settings.php

Sorry for my critics comment. I mean that my reaction helps you with better code. I can help you - ask me, when you can :-)

@chasebolt
Copy link

@o5 would love to see this PR merged in 👍 . it's nice to output the version of an app during CI testing.

@o5
Copy link
Contributor Author

o5 commented Jun 23, 2016

@chasebolt I spend 1 hour with this PR and I don't want more. Sorry.

@chasebolt
Copy link

@JakubOnderka can this get merged?

@JakubOnderka JakubOnderka merged commit 1d75387 into JakubOnderka:master Jul 10, 2016
@JakubOnderka
Copy link
Owner

@o5 Thanks for your pull request

@o5 o5 deleted the feature-option-version branch August 25, 2016 20:22
jrfnl pushed a commit to jrfnl/PHP-Parallel-Lint that referenced this pull request Dec 6, 2021
jrfnl added a commit to jrfnl/PHP-Parallel-Lint that referenced this pull request Dec 6, 2021
jrfnl added a commit to jrfnl/PHP-Parallel-Lint that referenced this pull request Mar 1, 2022
* Minor tweak to allow CS to pass.
* Enable SimpleXML for the PHP 5.3-5.5 tests.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants