Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds climate, hvac and temperature requests #35

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

JagCesar
Copy link
Owner

I need these for a feature I'm workin on for Volante.

JagCesar and others added 5 commits March 18, 2018 17:10
* Adds empty credentials file so tests compile

* Creates EmptyTests target

The empty tests are now run on the iOS scheme. Let's keep it like
this until we have mocked objects for the tests.

The purpose of doing this is to make sure our CI passes the builds.
Updates eu_vehicle and motorized_charge_port, both of these properties
are now optional.
} else {
XCTFail()
}
case .failure(_):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty Enum Arguments Violation: Arguments can be omitted when matching enums with associated types if they are not used. (empty_enum_arguments)

XCTFail()
}
case .failure(_):
XCTFail()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XCTFail Message Violation: An XCTFail call should include a description of the assertion. (xctfail_message)

if result == true {
waitExpectation.fulfill()
} else {
XCTFail()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XCTFail Message Violation: An XCTFail call should include a description of the assertion. (xctfail_message)

} else {
XCTFail()
}
case .failure(_):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty Enum Arguments Violation: Arguments can be omitted when matching enums with associated types if they are not used. (empty_enum_arguments)

} else {
XCTFail()
}
case .failure(_):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty Enum Arguments Violation: Arguments can be omitted when matching enums with associated types if they are not used. (empty_enum_arguments)

case .success(_):
waitExpectation.fulfill()
case .failure(_):
XCTFail()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XCTFail Message Violation: An XCTFail call should include a description of the assertion. (xctfail_message)


public struct HVACRequest: RequestProtocol {
public enum HVACState {
case on

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identifier Name Violation: Enum element name should be between 3 and 40 characters long: 'on' (identifier_name)

}
return
}
let responseDict = response as! [String: [String: Any]]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Force Cast Violation: Force casts should be avoided. (force_cast)

passengerTempSetting = dict["passenger_temp_setting"] as! Double
isAutoConditioningOn = dict["is_auto_conditioning_on"] as! Bool
isFrontDefrosterOn = dict["is_front_defroster_on"] as! Bool
isRearDefrosterOn = dict["is_rear_defroster_on"] as! Bool

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Force Cast Violation: Force casts should be avoided. (force_cast)

driverTempSetting = dict["driver_temp_setting"] as! Double
passengerTempSetting = dict["passenger_temp_setting"] as! Double
isAutoConditioningOn = dict["is_auto_conditioning_on"] as! Bool
isFrontDefrosterOn = dict["is_front_defroster_on"] as! Bool

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Force Cast Violation: Force casts should be avoided. (force_cast)

} else {
XCTFail()
}
case .failure(_):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty Enum Arguments Violation: Arguments can be omitted when matching enums with associated types if they are not used. (empty_enum_arguments)

XCTFail()
}
case .failure(_):
XCTFail()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XCTFail Message Violation: An XCTFail call should include a description of the assertion. (xctfail_message)

if result {
waitExpectation.fulfill()
} else {
XCTFail()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XCTFail Message Violation: An XCTFail call should include a description of the assertion. (xctfail_message)

} else {
XCTFail()
}
case .failure(_):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty Enum Arguments Violation: Arguments can be omitted when matching enums with associated types if they are not used. (empty_enum_arguments)

XCTFail()
}
case .failure(_):
XCTFail()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XCTFail Message Violation: An XCTFail call should include a description of the assertion. (xctfail_message)

if result {
waitExpectation.fulfill()
} else {
XCTFail()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XCTFail Message Violation: An XCTFail call should include a description of the assertion. (xctfail_message)

} else {
XCTFail()
}
case .failure(_):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty Enum Arguments Violation: Arguments can be omitted when matching enums with associated types if they are not used. (empty_enum_arguments)

XCTFail()
}
case .failure(_):
XCTFail()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XCTFail Message Violation: An XCTFail call should include a description of the assertion. (xctfail_message)

if result {
waitExpectation.fulfill()
} else {
XCTFail()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XCTFail Message Violation: An XCTFail call should include a description of the assertion. (xctfail_message)

} else {
XCTFail()
}
case .failure(_):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty Enum Arguments Violation: Arguments can be omitted when matching enums with associated types if they are not used. (empty_enum_arguments)

XCTFail()
}
case .failure(_):
XCTFail()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XCTFail Message Violation: An XCTFail call should include a description of the assertion. (xctfail_message)

if result {
waitExpectation.fulfill()
} else {
XCTFail()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XCTFail Message Violation: An XCTFail call should include a description of the assertion. (xctfail_message)

@JagCesar JagCesar changed the base branch from master to develop July 15, 2018 18:24
} else {
XCTFail()
}
case .failure(_):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty Enum Arguments Violation: Arguments can be omitted when matching enums with associated types if they are not used. (empty_enum_arguments)

XCTFail()
}
case .failure(_):
XCTFail()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XCTFail Message Violation: An XCTFail call should include a description of the assertion. (xctfail_message)

if result {
waitExpectation.fulfill()
} else {
XCTFail()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XCTFail Message Violation: An XCTFail call should include a description of the assertion. (xctfail_message)

} else {
XCTFail()
}
case .failure(_):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty Enum Arguments Violation: Arguments can be omitted when matching enums with associated types if they are not used. (empty_enum_arguments)

XCTFail()
}
case .failure(_):
XCTFail()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XCTFail Message Violation: An XCTFail call should include a description of the assertion. (xctfail_message)

if result {
waitExpectation.fulfill()
} else {
XCTFail()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XCTFail Message Violation: An XCTFail call should include a description of the assertion. (xctfail_message)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants