mimetype package to mimetype/browser #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: db1552c The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
... is issued with here |
|
Hello @dalbodeule, Thanks for the contribution! Can you run |
|
As a result of the test, some parts of tsconfig.json need to be further touched. I will post the results a little later. |
|
I completed the commit yesterday and confirmed that the build is proceeding normally. Additionally, some code modifications were completed. Please confirm and merge. |
JacobLinCool
approved these changes
May 30, 2024
|
Thanks for your contribution! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error seems to occur because cloudflare worker does not directly support the node module. This error seems to occur because the mimetext module has not yet been changed to browser support code.
So, I changed all the supported code to browser support code. Please PR after checking in your environment.