Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4: adding events #429

Merged
merged 5 commits into from
Apr 4, 2024
Merged

v4: adding events #429

merged 5 commits into from
Apr 4, 2024

Conversation

TheMarstonConnell
Copy link
Member

Adding events for websockets

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 87.68657% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 48.50%. Comparing base (5e4a32c) to head (6e76ab4).

Files Patch % Lines
x/storage/keeper/msg_server_file_delete.go 0.00% 13 Missing ⚠️
x/storage/keeper/msg_server_report.go 0.00% 12 Missing ⚠️
x/storage/keeper/msg_server_attest.go 66.66% 6 Missing ⚠️
x/storage/keeper/msg_server_post_file.go 88.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #429      +/-   ##
==========================================
+ Coverage   46.81%   48.50%   +1.68%     
==========================================
  Files         211      211              
  Lines        6577     6845     +268     
==========================================
+ Hits         3079     3320     +241     
- Misses       3240     3269      +29     
+ Partials      258      256       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@karnthis karnthis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my testing looks good, clear to proceed

@karnthis karnthis merged commit bb0971d into master Apr 4, 2024
11 checks passed
@TheMarstonConnell TheMarstonConnell deleted the marston/v4-events branch April 4, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants