Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Errors #396

Merged
merged 6 commits into from
Dec 28, 2023
Merged

Better Errors #396

merged 6 commits into from
Dec 28, 2023

Conversation

TheMarstonConnell
Copy link
Member

Cleaning up a bunch of junky errors with properly wrapped errors.

Ex: the buy storage would fail with an ambiguous message if the deposit message was not a proper bech32 address.

@TheMarstonConnell TheMarstonConnell self-assigned this Dec 28, 2023
@TheMarstonConnell TheMarstonConnell marked this pull request as ready for review December 28, 2023 18:28
Copy link
Member

@karnthis karnthis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheMarstonConnell TheMarstonConnell merged commit d07291e into master Dec 28, 2023
6 of 9 checks passed
@TheMarstonConnell TheMarstonConnell deleted the marston/better-errors branch December 28, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants