Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing old contracts after 100 blocks #220

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

TheMarstonConnell
Copy link
Member

Removes all unsigned contracts after 100 blocks

@TheMarstonConnell TheMarstonConnell added the enhancement New feature or request label Jan 26, 2023
if err != nil {
ctx.Logger().Error(err.Error())
}

k.KillOldContracts(ctx)

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
Copy link
Contributor

@BiPhan4 BiPhan4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built the chain locally and tested with a storage provider. Uploaded 20+ files without signing. Set a timer for 10 minutes and confirmed that unsigned contracts were removed.

@BiPhan4 BiPhan4 merged commit 31dc329 into bouncy-bulldog-rc Jan 26, 2023
@BiPhan4 BiPhan4 deleted the removing_old_contracts branch January 26, 2023 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants