Re-architect the generation module to use a builder pattern #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplified `dijkstra.cpp` to be more readable and easier to understand.
JackAshwell11
force-pushed
the
generation_refactor
branch
3 times, most recently
from
050b43c to
bec006a
Compare
…y construction of a dungeon using the `MapGenerator` class. This re-architect also introduced a bunch of other refactors massively simplifying various parts of the codebase and extracting out common functionality. Removed `Neighbour` and replaced it with `Connection` (a renamed version of `Edge`) allowing `Connection` to work for `map.hpp` and `dijkstra.hpp`. This also simplified the backtracking as we didn't have to find the source. Added `Grid::convert_position(int)` allowing the conversion of a 1D index into a 2D `Position`. Changed `Leaf::create_room()` so that `rooms` is now the center `Rect` position by default instead of the whole `Rect` object. Stopped `pathfind()` throwing an error as this caused a crash with `std::transform` if the grid is empty. Removed `LevelConstants::level`.
JackAshwell11
force-pushed
the
generation_refactor
branch
from
bec006a to
fe2bd3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR re-architects the generation module (specifically the
map.hppfile) to use a builder pattern allowingcreate_map()to become less complicated and adding the option for future expandability. It also introduces a bunch of other refactors to improve the overall code quality and make it simpler to understand and use.Type of Changes
Tasks
map.hpp.