Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always delete the .sav file upon successful write #9675

Merged
merged 5 commits into from
Mar 27, 2023
Merged

Conversation

koppor
Copy link
Member

@koppor koppor commented Mar 16, 2023

JabRef 5.10--2023-02-08--d708596
Windows 10 10.0 amd64 
Java 19.0.2 
JavaFX 19+11

JabRef did not delete the .sav file. RLY?

image

  • Option 1: When starting JabRef, it should delete obsolete .sav files - or check if there is a diff in the .bib and the .sav
  • Option 2: Delete .sav upon successful write, because we have "real" backups (.bak) in place - with a warning if the .bak differs from the .bib

I opted for Option 2.

Refs #9488 (comment)

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 17, 2023
calixtus
calixtus previously approved these changes Mar 17, 2023
@koppor koppor added this to the v5.10 milestone Mar 18, 2023
@Siedlerchr Siedlerchr merged commit 9acf64b into main Mar 27, 2023
@Siedlerchr Siedlerchr deleted the remove-sav-file branch March 27, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
export / save status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants