Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rm -f to ignore failures in rpm spec file #9604

Merged
merged 3 commits into from
Feb 8, 2023
Merged

Add rm -f to ignore failures in rpm spec file #9604

merged 3 commits into from
Feb 8, 2023

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Feb 7, 2023 •
edited
Loading

Fixes #9603
Fixes #9558

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers os: linux labels Feb 7, 2023
@Siedlerchr
Update jabref.spec
3bf3ad3 
Seems to be Desktop_SCRIPTS now instead of utility
ilippert
ilippert reviewed Feb 7, 2023
View reviewed changes
Copy link
Contributor

@ilippert ilippert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the build reported at #9558 (comment) works for me

calixtus
calixtus previously approved these changes Feb 8, 2023
View reviewed changes
@Siedlerchr
Copy link
Member Author

needs changelog entry

@Siedlerchr Siedlerchr merged commit d708596 into main Feb 8, 2023
@Siedlerchr Siedlerchr deleted the fixlinuxSpec branch February 8, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilippert ilippert ilippert left review comments

@calixtus calixtus calixtus left review comments

Assignees
No one assigned
Labels
os: linux status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jabref install rpm not working spec file rpm preventing removal
3 participants
@Siedlerchr @ilippert @calixtus