Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix libraries not being remembered when an unsaved library is discarded upon closing JabRef #9250

Closed
wants to merge 7 commits into from

Conversation

tomnguye
Copy link

@tomnguye tomnguye commented Oct 14, 2022

Fixes #9190

Made it so that when closing the app if the focused database is not saved look for the first saved open database to set as focused.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor
Copy link
Member

koppor commented Oct 14, 2022

Seems like a (working) quick fix, but not solving the underlying issue. Maybe, the direction is more into the listeners. See #9238 for a discussion.

@tomnguye
Copy link
Author

I think I need more information to go off of here. Could you describe how my implementation misses the underlying issue? otherwise what event do you feel requires listening?

@tomnguye tomnguye marked this pull request as draft October 17, 2022 04:00
@tomnguye tomnguye marked this pull request as ready for review October 23, 2022 01:20
@tomnguye
Copy link
Author

I've made a change to the 'focused library' event listener that I hope better addresses the issue. Please point out if the revised fix has any issues

@koppor
Copy link
Member

koppor commented Nov 2, 2022

What happens at step 6 with your fix?

grafik

Maybe you can upload a video using Loom

@ThiloteE ThiloteE added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Nov 18, 2022
@koppor
Copy link
Member

koppor commented Dec 19, 2022

This PR doesn't seem to fix the issue. See new comments at #9190 (comment).

@koppor koppor closed this Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
export / save status: waiting-for-feedback The submitter or other users need to provide more information about the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JabRef forgets opened libraries
3 participants