Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jakarta annotation missing #9183

Merged
merged 8 commits into from
Sep 27, 2022
Merged

Fix jakarta annotation missing #9183

merged 8 commits into from
Sep 27, 2022

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Sep 26, 2022 •
edited
Loading

Fixes #9176

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@calixtus
Copy link
Member

grafik

@Siedlerchr
Copy link
Member Author

It works now. The deps are only cached here. So the latest snapshot is not getting pulled

@Siedlerchr
Copy link
Member Author

Tested it locally with jpackage and it works. We need to have a proper release of the afterburner stuff soon
Currently we are only using jitpack snapshot JabRef/afterburner.fx#5

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 26, 2022
calixtus
calixtus approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@calixtus calixtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

koppor
koppor reviewed Sep 26, 2022
View reviewed changes
Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can then delete https://github.com/JabRef/jabref/blob/main/lib/afterburner.fx.jar, can't we?

@Siedlerchr
Copy link
Member Author

We can then delete https://github.com/JabRef/jabref/blob/main/lib/afterburner.fx.jar, can't we?

That should already bee part of this pr

@Siedlerchr Siedlerchr merged commit 0ed4569 into main Sep 27, 2022
@Siedlerchr Siedlerchr deleted the fixJakarta branch September 27, 2022 17:25
@Siedlerchr Siedlerchr mentioned this pull request Sep 27, 2022
Closed
2 tasks
Siedlerchr added a commit to LIM0000/jabref that referenced this pull request Oct 3, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-for-issue-8189
f068634 
* upstream/main: (27 commits)
  Bump slf4j-api from 2.0.2 to 2.0.3 (JabRef#9207)
  Bump slf4j-api from 2.0.2 to 2.0.3 in /buildSrc (JabRef#9211)
  Add mappings on ModsImporter.java (JabRef#9193)
  Improve installation of java 18 in devcontainer (JabRef#9197)
  Fix missing title for "customize entry types" (JabRef#9198) (JabRef#9201)
  Squashed 'buildres/csl/csl-locales/' changes from b2afeb4d87..cb98d36691
  Squashed 'buildres/csl/csl-styles/' changes from 201e022..7bde3e4
  "Capitalize" capitalizes words after hyphens (JabRef#9186)
  Observable Preferences O (Language and FileHistory) (JabRef#9173)
  Fix jakarta annotation missing (JabRef#9183)
  Bump junit-platform-launcher from 1.9.0 to 1.9.1 (JabRef#9177)
  Bump WyriHaximus/github-action-wait-for-status from 1.6 to 1.7.1 (JabRef#9178)
  Bump junit-jupiter from 5.9.0 to 5.9.1 (JabRef#9180)
  Bump checkstyle from 10.3.3 to 10.3.4 (JabRef#9179)
  Bump slf4j-api from 2.0.1 to 2.0.2 (JabRef#9181)
  Bump slf4j-api from 2.0.1 to 2.0.2 in /buildSrc (JabRef#9182)
  Remove Java Flight Recorder (JabRef#9174)
  Fixes fetcher tests (JabRef#9175)
  Update afterburner to jakarta (JabRef#9168)
  Improve startup-behavior of pdf indexer (JabRef#9166)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koppor koppor koppor left review comments

@calixtus calixtus calixtus approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JabRef build 2022-09-25 20:56 does not start
3 participants
@Siedlerchr @calixtus @koppor