Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devdocs about fetchers #9146

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Update devdocs about fetchers #9146

merged 1 commit into from
Sep 7, 2022

Conversation

ThiloteE
Copy link
Member

@ThiloteE ThiloteE commented Sep 7, 2022

old:

  • table was displayed correctly on github via markdown
  • table was NOT displayed correctly at the devdocs webpage

new:

  • table is displayed correctly on github via markdown
  • table is displayed correctly at the devdocs webpage

See https://devdocs.jabref.org/code-howtos/fetchers.html

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

old:
- table was displayed correctly on github via markdown
- table was NOT displayed correctly at the devdocs webpage

new:
- table is displayed correctly on github via markdown
- table is displayed correctly at the devdocs webpage

See https://devdocs.jabref.org/code-howtos/fetchers.html
@ThiloteE
Copy link
Member Author

ThiloteE commented Sep 7, 2022

I am not sure how to test correct display of html without merging this pull-request

@Siedlerchr
Copy link
Member

@ThiloteE On the files changes tab .> Display the rich diff will show you the rendered markdown

@Siedlerchr Siedlerchr merged commit 114dbd0 into main Sep 7, 2022
@Siedlerchr Siedlerchr deleted the devdocsfetchers branch September 7, 2022 18:14
Siedlerchr added a commit to LIM0000/jabref that referenced this pull request Sep 10, 2022
* upstream/main:
  Anomaly with Title case and Sentence case JabRef#9112 (JabRef#9142)
  Fixed save order config (JabRef#9148)
  Update devdocs about fetchers (JabRef#9146)
  Set 'Update refused' dialog title (JabRef#9143)
  Bump jackson-datatype-jsr310 from 2.13.3 to 2.13.4 (JabRef#9136)
  Bump jackson-dataformat-yaml from 2.13.3 to 2.13.4 (JabRef#9138)
  Observable Preferences N (PushToApplicationPreferences, ExternalApplicationPreferences) (JabRef#9135)
  Resimplify Action interface (JabRef#9133)
  Fix issue with empty fallback directory (JabRef#9134)
  Fix indexing (JabRef#9132)
  SLR data is now editable (JabRef#9131)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants