-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDFs are not stored next to .bib file if file directory is configured #9113
Conversation
…ectory. Co-authored-by: Kevin Klein <[email protected]>
… "JabRef" in the user's home Co-authored-by: Kevin Klein <[email protected]>
Co-authored-by: Kevin Klein <[email protected]>
How does this correlate with the Checkbox ticked "Search and store files relative to the bib library directory?" |
This is the long description of following new (!) code: if (fileDirs.isEmpty() && preferences.shouldStoreFilesRelativeToBibFile()) { Should I add this as text or would it be clear from the code itself? |
…ser-directory-first # Conflicts: # CHANGELOG.md
Major problem: swing reintroduced in JabRefPreferences, architecture tests are failing and future modularization is at risk |
Deciscions: Move to OS or Desktop class |
remove obsolete checks
CleanupWorker fails cleanupRenamePdfRenamesRelativeFile and cleanupRelativePathsConvertAbsoluteToRelativePath |
This reverts commit 279ae2e.
Co-authored-by: Christoph <[email protected]>
* upstream/main: Fix link and remove obsolete FAQ Rename 'Close' to 'Cancel' in the External Changes Resolver dialog (#9130) Tiny rephrasing Linked files with an absolute path can be opened again (#9129) Oberservable Preferences M (CleanupPreferences) (#9126) fix broken link Fix broken link Fix old JabRef linked files containing the file directory as element in the filename (#9046) PDFs are not stored next to .bib file if file directory is configured (#9113) Remove double stateManager.activeDatabaseProperty() (#9127) Don't show the info button when the authors field content is identical (#9128)
* upstream/main: (111 commits) Fix link and remove obsolete FAQ Rename 'Close' to 'Cancel' in the External Changes Resolver dialog (JabRef#9130) Tiny rephrasing Linked files with an absolute path can be opened again (JabRef#9129) Oberservable Preferences M (CleanupPreferences) (JabRef#9126) fix broken link Fix broken link Fix old JabRef linked files containing the file directory as element in the filename (JabRef#9046) PDFs are not stored next to .bib file if file directory is configured (JabRef#9113) Remove double stateManager.activeDatabaseProperty() (JabRef#9127) Don't show the info button when the authors field content is identical (JabRef#9128) "study.yml" is static now (JabRef#9125) fix l10n Compile fix Fix parsing of JabRef v5.7 study.yml files (JabRef#9124) Fix integrity check for tilde accents in author names (JabRef#9097) Rework the Define study parameters dialog (JabRef#9123) Fix parsing of save actions (JabRef#9122) Fix exception that occurs when saving name formatters (JabRef#9121) Refine code for BibEntry#replaceDownloadedFile (JabRef#9118) ...
We had following issue:
Inspecting the code, the reason probably is that the database file directory is accessible on Windows only, but not on Mac OS X. Thus, during download, JabRef did a fallback on the directory of the .bib file.
This PR fixes it:
JabRef
sub directory:CHANGELOG.md
described in a way that is understandable for the average user (if applicable)