Fix issue 9068 - Fixing letter capitalization after hyphen or dash between 2 terms.

[Luan-Cavalcante]

What :
I implemented a change in the Word.java file so that I can capitalize titles, with the capitalize function, that have a hyphen or a dash inside two terms. Like enzyme-catalyzed.

Why :
To solve the issue [#9068].

Context:
I am currently studying tests in University and the Professor proposed a TDD application in JabRef.

• Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
• Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

[calixtus]

Hi @Luan-Cavalcante , thanks for your interest in jabref and your PR. On first look are some issues with your code.

• please try to match our code style requirements, so we can keep our codebase consistent. We provide configs for Checkstyle and intellij idea. Please follow the instructions on setting up your workspace for jabref programming in our dev docs.
• you deleted several lines in our changelog for no reason.
• it seems like you hardcoded in some very few cases. Maybe there is another easy way to make this more generic?

Also I noticed that you and your colleagues from programming class all tried to solve the same issue. This is a bit sad, since this leads to a lot of lost work, as we will only include one solution in the final merge. Also it will put a lot of work on us, the maintainers, to review all the PRs. We love teaching open source programming, but we do this all in our spare time along our day jobs.
Please ask your professor to contact us, so we can talk about best practices that work with us and other programming classes for next time.

Thanks!

[Luan-Cavalcante]

Hi, you're welcome! Yeah, a lot of guys worked on the same issue, but I think it was because this issue was the easiest one and the deadline was really close. I'm sorry for making that mess in the changelog, my professor is working with jabref for a long time to teach software testing. It's a really good project. I am getting in touch with my professor as soon as possible, thank you for the feedback. And good job. Em seg., 29 de ago. de 2022 às 01:21, Carl Christian Snethlage < ***@***.***> escreveu:

…

Hi @Luan-Cavalcante <https://github.com/Luan-Cavalcante> , thanks for your interest in jabref and your PR. On first look are some issues with your code. - please try to match our code style requirements, so we can keep our codebase consistent. We provide configs for Checkstyle and intellij idea. Please follow the instructions on setting up your workspace for jabref programming in our dev docs. - you deleted several lines in our changelog for no reason. - it seems like you hardcoded in some very few cases. Maybe there is another easy way to make this more generic? Also I noticed that you and your colleagues from programming class all tried to solve the same issue. This is a bit sad, since this leads to a lot of lost work, as we will only include one solution in the final merge. Also it will put a lot of work on us, the maintainers, to review all the PRs. We love teaching open source programming, but we do this all in our spare time along our day jobs. Please ask your professor to contact us, so we can talk about best practices that work with us and other programming classes for next time. Thanks! — Reply to this email directly, view it on GitHub <#9100 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AP7LOMSYIOIGGWA5DYJE7FTV3Q3DRANCNFSM573ZWT7A> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[calixtus]

Ok, thanks. No big deal.
JabRef is not just a simple open source java project, but is also dedicated to support teaching java and open source. See https://devdocs.jabref.org/teaching.html

Good luck with your studies!