-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Automatic Field Editor Dialog #8973
Merged
Merged
Changes from 2 commits
Commits
Show all changes
81 commits
Select commit
Hold shift + click to select a range
376760c
Update README.md
HoussemNasri d898da1
Merge branch 'JabRef:main' into main
HoussemNasri 752954b
Merge branch 'JabRef:main' into main
HoussemNasri 41b499f
Merge branch 'JabRef:main' into main
HoussemNasri a63045f
Merge branch 'JabRef:main' into main
HoussemNasri 0901768
Merge branch 'JabRef:main' into main
HoussemNasri 5874b4e
Merge remote-tracking branch 'origin/main' into main
HoussemNasri 3c3fb02
Fix Readme
HoussemNasri 81815fa
Merge branch 'JabRef:main' into main
HoussemNasri 18d95c2
Merge branch 'JabRef:main' into main
HoussemNasri 0e08af3
Merge branch 'JabRef:main' into main
HoussemNasri 2bb0b6c
Merge branch 'JabRef:main' into main
HoussemNasri d71f93a
Commit
HoussemNasri 57005ce
Merge branch 'JabRef:main' into main
HoussemNasri fffc86c
Update README.md
HoussemNasri 4f480ba
Merge remote-tracking branch 'origin/main' into main
HoussemNasri 63e09ba
Merge branch 'JabRef:main' into main
HoussemNasri 365e968
Merge remote-tracking branch 'origin/main' into main
HoussemNasri 033b9a2
Revert "Commit"
HoussemNasri 1303d3c
Don't copy field value if it doesn't exist
HoussemNasri a4b5e3e
Refactor TwoFields tab to make it easier to test
HoussemNasri fd1006e
Test TwoFieldsViewModel
HoussemNasri 2a1a298
Add more tests for TwoFieldsViewModel
HoussemNasri a8adb0b
Rename dialog's 'Revert' button to 'Cancel'
HoussemNasri 0879542
Rename 'value' to 'content'
HoussemNasri 675ed00
Make field ComboBox editable
HoussemNasri 2bbb097
Update ComboBox field list when a new field is added
HoussemNasri ec75377
Rename "Overwrite Non empty fields" to "Overwrite field content"
HoussemNasri 72e9287
Cancel changes when the dialog is closed using the X button
HoussemNasri 120c63c
Revert "Cancel changes when the dialog is closed using the X button"
HoussemNasri 0f9734a
Prevent JavaFX from firing CANCEL_CLOSE event
HoussemNasri 7e58326
Show field display name in ComboBox
HoussemNasri d2f2b8a
Clear old field list before adding the new list
HoussemNasri bbe27b0
Rename 'TwoFields' to 'CopyOrMoveFieldContent'
HoussemNasri a70f750
i18n
HoussemNasri 3a055ee
Rename package to copyormovecontent
HoussemNasri ccfd331
Make the set of visible fields observable
HoussemNasri b0accbf
Bind fields ComboBox to visible fields in BibDatabase
HoussemNasri b012f5d
Checkstyle
HoussemNasri 4d6cd83
Make visibleFields set modifiable
HoussemNasri e2edbe1
Select first item in the ComboBox after fields set is updated
HoussemNasri 46673e4
Bind RenameFieldTabView's combobox to visible fields set
HoussemNasri 4663df5
Allow users to move or copy content from one field to a NEW field
HoussemNasri c1f2bf2
Bind CopyOrMoveFieldContentTabView's from/to fields combobox to visib…
HoussemNasri 839454f
Remove the binding between visible fields in BibDatabase and ComboBox…
HoussemNasri 35c3146
Add Standard fields even when visible fields set is empty
HoussemNasri bad23ae
Make all ComboBox(s) editable
HoussemNasri 8652b58
Pass BibDatabase rather than BibDatabaseContext to field editor tabs
HoussemNasri b115260
Bind UI to view model and not the other way around
HoussemNasri e851dc0
Add getSelectedField() to EditFieldContentViewModel
HoussemNasri 5bb34ff
Test EditFieldContentTabViewModel
HoussemNasri 1e9dfc4
Remove System.out.println
HoussemNasri 452d212
Show a notification to indicate the number of affected entries when a…
HoussemNasri c27b835
Don't register copy edit if the copy action is not performed
HoussemNasri ed18b44
Show affected rows notification when field values are swapped
HoussemNasri f9c45f9
Show affected rows notification when field values are set/cleared or …
HoussemNasri 0e8c9a4
Add methods to register/unregister event bus to RenameFieldTabView
HoussemNasri 2522645
Post a notification event when field is renamed or when field value i…
HoussemNasri 0d44a15
Remove Notification Pane's transparent background style
HoussemNasri f06b212
Display the notification pane for 2 seconds
HoussemNasri b41033f
Convert AutomaticFieldEditorEvent to a record
HoussemNasri 8011f30
Filter out blank field names
HoussemNasri e87dc4c
Reuse FIELD_STRING_CONVERTER from CustomEntryTypeDialogViewModel
HoussemNasri a5c84fa
Disable rename field button when either field ComboBox or new field n…
HoussemNasri 3ceec86
Display an error if new field name has any whitespace characters
HoussemNasri 2146766
Validate user input in EditFieldContentTabView
HoussemNasri aaa7814
Refactor
HoussemNasri dd7875d
Validate user input in CopyOrMoveFieldContentTabView
HoussemNasri cdc88ab
Test RenameFieldViewModel
HoussemNasri 872839f
Convert to field display name as user types text in fromFieldComboBox
HoussemNasri 9016c1a
Update 'containsWhitespace' implementation
HoussemNasri edc9f3e
Test containsWhitespace
HoussemNasri f80232a
Increase StringUtil maximum line count to 765
HoussemNasri 96c7ea8
Stop using event bus in EditFieldContentTabView
HoussemNasri e925826
Stop using event bus in the other tabs
HoussemNasri d89f691
Delete AutomaticFieldEditorEvent.java
HoussemNasri 1c9f063
Minimize number of constructor arguments
HoussemNasri e9a7716
Update tests
HoussemNasri 6b86397
Work around exception
koppor f59c5f5
Fix casing
koppor f37c5f8
Convert to ParameterizedTests
koppor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You now need to adapt the failing architecture test to the new size of the StringUtil class.
PS: I wasn't aware of the String.chars method, that's neat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Increased it to 765