Add: Add test cases for non-default styles in CitationStyleTest #8828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added test cases to check citation styles for: - ACM SIGGRAPH - American Psychological Association 6th edition Also, added test case for discoverCitationStyles to improve code coverage of the CitationStyle class.
remove unnecessary blank space, added appropriate exception
ThiloteE
added
the
type: code-quality
Siedlerchr
approved these changes
May 21, 2022
Siedlerchr
added
the
status: ready-for-review
|
I'm good with the test for discovercitationstyles. I'm not so sure about the two test for the styles. You basically do the test work for csl in our package. I think the two tests are just misplaced here, as they don't really test our logic, but the logic of csl... |
|
I was not sure about that either, We also have those in CitationStyleGeneratorTest where we test issue/number etc fields |
* upstream/main: Fix right clicking a group and choosing "remove selected entries from this group" leads to error when Bibtex source tab is selected (JabRef#8821) Fix single identifier cannot be opened on click (JabRef#8838) Add Pubmed/Medline Query Transformer (JabRef#8818) adjust and add testcases for FileAnnotationViewModel (JabRef#8830) Append config instead of replacing (JabRef#8834) Fix eclipse config (JabRef#8835) Add Nemo file manager (JabRef#8831) Fix missing clear action on pressing esc within the "Filter groups" field (JabRef#8829)
|
I've moved the two style specific tests to CitationStyleGeneratorTest class |
Siedlerchr
added a commit
to fly-ing-fish/jabref
that referenced
this pull request
May 22, 2022
…-masked-characters#8787 * upstream/main: Add: Add test cases for non-default styles in CitationStyleTest (JabRef#8828) Open event log when clicking on collapsed notification (JabRef#8837) Fix right clicking a group and choosing "remove selected entries from this group" leads to error when Bibtex source tab is selected (JabRef#8821) Fix single identifier cannot be opened on click (JabRef#8838) Add Pubmed/Medline Query Transformer (JabRef#8818) adjust and add testcases for FileAnnotationViewModel (JabRef#8830) Append config instead of replacing (JabRef#8834) Fix eclipse config (JabRef#8835) Add Nemo file manager (JabRef#8831) Fix missing clear action on pressing esc within the "Filter groups" field (JabRef#8829) Update bouncycalse to new base version (JabRef#8827) add: add test cases for FileUtil (JabRef#8810) Restrict use of standard streams (JabRef#8816)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding test cases to help improve testing for the citation styles.
Added two test cases to check citation styles non-default (IEEE) styles as the other styles were not being tested. Added testACMCitation and testAPACitation to cover the corresponding citation styles, which are imported from (build/resources/main/csl-styles/acm-siggraph.csl) and (build/resources/main/csl-styles/apa-6th-edition.csl). Also, added a test case for discoverCitationStyles to improve code coverage for the CitationStyle class.
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)