Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to select and open identifiers (e.g. URL, DOI, etc.) from a popup-list in the maintable #8813

Closed
wants to merge 1 commit into from
Closed

Allow to select and open identifiers (e.g. URL, DOI, etc.) from a popup-list in the maintable #8813

wants to merge 1 commit into from

Conversation

Rifat951
Copy link
Contributor

@Rifat951 Rifat951 commented May 17, 2022 •
edited by ThiloteE
Loading

fixes #8758
fixes #8802

  • click and select either doi or url is possible and hyperlinks pops up as well. Simply changing the Mousebutton.Primary to Mousebutton.Seconday solved the issue

test

@ThiloteE ThiloteE changed the title Update LinkedIdentifierColumn.java Allow to open other identifiers than only the first one from maintable (e.g. URL, DOI, etc.) May 17, 2022
@ThiloteE ThiloteE changed the title Allow to open other identifiers than only the first one from maintable (e.g. URL, DOI, etc.) Allow to select and open identifiers (e.g. URL, DOI, etc.) from a popup-list in the maintable May 17, 2022
@Siedlerchr
Copy link
Member

LGTM!

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label May 17, 2022
@Siedlerchr
Copy link
Member

Please add a changelog entry!

@Rifat951
Copy link
Contributor Author

I will raise PR from a different branch as per best git practices. Since, i have used main branch.

@Rifat951 Rifat951 closed this May 17, 2022
@Rifat951 Rifat951 mentioned this pull request May 17, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintable status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers ui
Projects
None yet
Milestone
No milestone
3 participants
@Rifat951 @Siedlerchr @ThiloteE