Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine checkstyle #8688

Merged
merged 9 commits into from
Apr 19, 2022
Merged

Refine checkstyle #8688

merged 9 commits into from
Apr 19, 2022

Conversation

koppor
Copy link
Member

@koppor koppor commented Apr 18, 2022

Since my last checkstyle PR #6283 new versions of checkstyle have been released. I went through the changelog (https://checkstyle.sourceforge.io/releasenotes.html) and added new interesting rules. Here the result.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor added type: code-quality Issues related to code or architecture decisions status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Apr 18, 2022
@Siedlerchr Siedlerchr merged commit a022324 into main Apr 19, 2022
@Siedlerchr Siedlerchr deleted the refine-checkstyle branch April 19, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers type: code-quality Issues related to code or architecture decisions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants