Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix zbMath fetcher #8623

Merged
merged 3 commits into from
Mar 28, 2022
Merged

Fix zbMath fetcher #8623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f9224c
Fix zbMath fetcehr
Siedlerchr Mar 28, 2022
21d9800
change to unkown field
Siedlerchr Mar 28, 2022
047cd5b
fix zbl number
Siedlerchr Mar 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/org/jabref/model/entry/field/StandardField.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,10 @@ public enum StandardField implements Field {
YEAR("year", FieldProperty.NUMERIC),
YEARFILED("yearfiled"),
MR_NUMBER("mrnumber"),
ZBL_NUMBER("zbl"),
XDATA("xdata", FieldProperty.MULTIPLE_ENTRY_LINK),
XREF("xref", FieldProperty.SINGLE_ENTRY_LINK),
// needed for the fetcher
ZBL_NUMBER("zbl"),

// JabRef-specific fields
GROUPS("groups"),
Expand All @@ -146,7 +147,6 @@ public enum StandardField implements Field {
CREATIONDATE("creationdate", FieldProperty.DATE),
MODIFICATIONDATE("modificationdate", FieldProperty.DATE);


private final String name;
private final String displayName;
private final Set<FieldProperty> properties;
Expand Down
1 change: 1 addition & 0 deletions src/test/java/org/jabref/logic/importer/fetcher/ResearchGateTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ void performSearchWithBibEntry() throws FetcherException {
}

@Test
@DisabledOnCIServer("CI server is unreliable")
void performSearchWithTitleWithCurlyBraces() throws FetcherException {
BibEntry entryInput = new BibEntry(StandardEntryType.Misc)
.withField(StandardField.TITLE, "Communicating {COVID}-19 against the backdrop of conspiracy ideologies: {HOW} {PUBLIC} {FIGURES} {DISCUSS} {THE} {MATTER} {ON} {FACEBOOK} {AND} {TELEGRAM}");
Expand Down
7 changes: 4 additions & 3 deletions src/test/java/org/jabref/logic/importer/fetcher/ZbMATHTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import org.jabref.logic.importer.ImportFormatPreferences;
import org.jabref.model.entry.BibEntry;
import org.jabref.model.entry.field.StandardField;
import org.jabref.model.entry.field.UnknownField;
import org.jabref.model.entry.types.StandardEntryType;
import org.jabref.testutils.category.FetcherTest;

Expand All @@ -33,18 +34,18 @@ void setUp() throws Exception {
donaldsonEntry = new BibEntry();
donaldsonEntry.setType(StandardEntryType.Article);
donaldsonEntry.setCitationKey("zbMATH03800580");
donaldsonEntry.setField(StandardField.AUTHOR, "S. K. {Donaldson}");
donaldsonEntry.setField(StandardField.AUTHOR, "Donaldson, S. K.");
donaldsonEntry.setField(StandardField.JOURNAL, "Journal of Differential Geometry");
donaldsonEntry.setField(StandardField.DOI, "10.4310/jdg/1214437665");
donaldsonEntry.setField(StandardField.ISSN, "0022-040X");
donaldsonEntry.setField(StandardField.LANGUAGE, "English");
donaldsonEntry.setField(StandardField.KEYWORDS, "57N13 57R10 53C05 58J99 57R65");
donaldsonEntry.setField(StandardField.KEYWORDS, "57N13,57R10,53C05,58J99,57R65");
donaldsonEntry.setField(StandardField.PAGES, "279--315");
donaldsonEntry.setField(StandardField.PUBLISHER, "International Press of Boston, Somerville, MA");
donaldsonEntry.setField(StandardField.TITLE, "An application of gauge theory to four dimensional topology");
donaldsonEntry.setField(StandardField.VOLUME, "18");
donaldsonEntry.setField(StandardField.YEAR, "1983");
donaldsonEntry.setField(StandardField.ZBL_NUMBER, "0507.57010");
donaldsonEntry.setField(new UnknownField("zbmath"), "3800580");
}

@Test
Expand Down