Fix missing search index dir #8581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
added
the
status: ready-for-review
Siedlerchr
pushed a commit
that referenced
this pull request
Mar 26, 2022
* Design the preference section for adding custom SSL certificates * Inject custom certificates FXML views into the controller * Delete unused import * Allow for enabling or disabling custom certificates * Use LocalDate instead of LocalDateTime for tracking certificate validity * Populate CustomCertificateViewModel with data from SSLCertificate - Added a method to map X509Certificate to SSLCertificate * Setup cell factory and populate the table with dummy data * Add '.cer' to StandardFileType * Open file explorer on 'Add certificate' clicked * Copy JDK 17 truststore into project resources * Bump JavaFX from 17.0.2 to 18 (#8577) * Bump JavaFX from 17.0.2 to 18 * Remove mac os hack for maintable Copy Preview content and not entry Co-authored-by: Siedlerchr <[email protected]> * Fix missing search index dir (#8581) Fixes #8579 * Log user added certificates information * Add an alias property to SSLCertificate that is generated randomly - A keystore contains a list of certificate entries, each of which is identified by a unique alias. For now, I'll generate aliases at random, but in the future, it would be better if users entered them. * Create TrustStoreManager for truststore manipulation * Add SSLPreferences * Set custom certificate preferences defaults * Persist 'useCustomCertificate' boolean preference * Use certificate thumbprint as an alias For the alias to be useful it has to be unique, I thought about using the serial number, but it is only unique for the CA, so I created a hash of all fields in the certificate * Delete dummy certificates and use real imported certificate information * Move certificate version formatting logic to the view * Move TrustStoreManager from GUI to Logic * Use Integer to store version instead of primitive int * Persist thumbprint, version, validFrom and validTo columns * Use localized strings * Fix failing test * Persist all certificate columns * Load truststore path from preferences * Deprecate bypassSSLVerification() and delete its usage - I didn't delete it because users might want to enable ssl bypassing from SSL configuration * Set truststore path at startup * Store truststore path in preference * Update CHANGELOG.md * Add an icon to 'Add certificate' button * Update truststore file on save preference * Clear all custom certificates from the truststore at preference reset * Use truststore as the single source of truth * Show warning dialog on attempting to add a duplicate certificate - Minor refactoring - Added certificate deletion to UI - i18n * Stop allowing for toggling custom certificates usage * Delete SSL certificates * Fix failing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8579
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)