-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve File Creation Issue With Medline/PubMed #8552
Changes from 4 commits
7e6a343
1a483a8
da996ba
4039011
f5cb17f
2834b4b
6d46dbc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,6 +60,9 @@ public void testWhetherAllFilesAreCreated() throws Exception { | |
|
||
assertTrue(Files.exists(Path.of(tempRepositoryDirectory.toString(), hashCodeQuantum + " - Quantum", "result.bib"))); | ||
assertTrue(Files.exists(Path.of(tempRepositoryDirectory.toString(), hashCodeCloudComputing + " - Cloud Computing", "result.bib"))); | ||
|
||
assertTrue(Files.exists(Path.of(tempRepositoryDirectory.toString(), hashCodeQuantum + " - Quantum", "Medline_PubMed.bib"))); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wonder if it makes sense to convert this test to a parameterized unit test. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We would need multiple "study.yml" files, so... yeah, let me know what you think would be better |
||
assertTrue(Files.exists(Path.of(tempRepositoryDirectory.toString(), hashCodeCloudComputing + " - Cloud Computing", "Medline_PubMed.bib"))); | ||
assertTrue(Files.exists(Path.of(tempRepositoryDirectory.toString(), "studyResult.bib"))); | ||
} | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,9 +60,10 @@ public void getActiveFetcherInstances() throws Exception { | |
StudyDatabaseToFetcherConverter converter = new StudyDatabaseToFetcherConverter(studyRepository.getActiveLibraryEntries(), importFormatPreferences); | ||
List<SearchBasedFetcher> result = converter.getActiveFetchers(); | ||
|
||
Assertions.assertEquals(2, result.size()); | ||
Assertions.assertEquals(3, result.size()); | ||
Assertions.assertEquals(result.get(0).getName(), "Springer"); | ||
Assertions.assertEquals(result.get(1).getName(), "ArXiv"); | ||
Assertions.assertEquals(result.get(2).getName(), "Medline/PubMed"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In general, it is better you compare two collections directly, this makes it easier to spot differences in case of failure. |
||
} | ||
|
||
private void copyTestStudyDefinitionFileIntoDirectory(Path destination) throws Exception { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,5 +12,6 @@ queries: | |
databases: | ||
- name: Springer | ||
- name: ArXiv | ||
- name: Medline/PubMed | ||
- name: IEEEXplore | ||
enabled: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.