Add confirmation dialog for empty entries in JabRef #8218
Conversation
| * @return true if the database has any empty entries; otherwise false | ||
| */ | ||
| public boolean hasEmptyEntries() { | ||
| for (BibEntry currentEntry: this.getEntries()) { |
There was a problem hiding this comment.
You can use streams here:
return this.getEntries().stream().anyMatch(entry->entry.getFields().isEmpty())
There was a problem hiding this comment.
Thank you! I have updated the function.
| if (response.isPresent() && response.get().equals(deleteEmptyEntries)) { | ||
| // The user wants to delete. | ||
| try { | ||
| for (BibEntry currentEntry : new ArrayList<BibEntry>(context.getEntries())) { |
There was a problem hiding this comment.
Why do you create a new array list here?
There was a problem hiding this comment.
If I don't create a new array list, removing the empty entry from the original array list will lead to out of index error.
There was a problem hiding this comment.
Are there any other approaches you would recommend? @Siedlerchr
There was a problem hiding this comment.
Ah yes, now I see it. It's because you can't remove an entry from a collection over that you are still iterating. So your solutions is fine.
Please add one more test where you check and verify that the context.getEntries() is indeed entry
e.e.g assertEquals(Collections.emptyList(), context.getEntries())
There was a problem hiding this comment.
Yes, exactly.
In @test withEmptyEntry() I have added a delete command and a test to check the database is empty after deleting. Would this be sufficient, or would you like me to add a test to actually test the function confirmEmptyEntry() that I added in JabRefFrame.java? Thanks!
Siedlerchr
added
the
status: ready-for-review
add one more test to verify that the database is empty after deleting
|
@ruoyu-qian Congratulations for your first GitHub contribution ever. Thank you for choosing JabRef! We are looking forward to more contributions! |
@koppor Thank you! Thanks a lot to @Siedlerchr for reviewing my PR. I feel like JabRef is a very supportive community. It's been a great experience! I look forward to working with you all more. 😄 |
* upstream/main: (181 commits) Add of ADRs 22 and 23 (#8256) [Bot] Update CSL styles (#8245) Replace styfle/[email protected] by GitHub's "concurrency" feature (#8243) Bump gittools/actions from 0.9.10 to 0.9.11 (#8248) Bump commons-cli from 1.4 to 1.5.0 (#8250) Bump byte-buddy-parent from 1.12.0 to 1.12.1 (#8249) Bump antlr4 from 4.9.2 to 4.9.3 (#8251) Bump archunit-junit5-api from 0.21.0 to 0.22.0 (#8252) Fix search: NOT binds more than AND (#8241) New Crowdin updates (#8240) Make PdfGrobiImporterTest as FetcherTest Oobranch g : add actions (#7792) Fix mixed CRLF / CR (#8238) Fix "Library has changed externally" with CRLF markers (#8239) Fix for issue 8198, 8133 (#8229) Added more unit tests in AuthorTest (#8214) Add confirmation dialog for empty entries in JabRef (#8218) Fix entry editor column visibility (#8232) Use regexp to remove non-ASCII characters from DOI and inform user when data for valid DOI does not exist #8127 (#8228) Fix exception for search flags (#8237) ...
Fixes #8096
Logic:
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)