Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default directory of the "LaTeX Citations" tab #8209

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

koppor
Copy link
Member

@koppor koppor commented Nov 3, 2021

Fixes koppor#538

The directory of the currently opened database is now used as default directory for the LaTeX Ciations Tab

Before

grafik

grafik

After

grafik

grafik


I did not dare to touch the logic of saving the "LatexFileDirectories". IMHO, they should be relative to the .bib file. This will be a longer discussion for a follow-up PR.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

…ry of the currently opened database

- Extracted method getInitialDirectory from ExistingStudySearchAction to FileUtil.java
- Adapted LatexCitations code
- Adapted TeXgroup selection code (context: Group -> Aux file)
- Fixed typos in CHANGELOG.md
Copy link
Contributor

@btut btut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Siedlerchr Siedlerchr merged commit 1bf28b3 into main Nov 5, 2021
@Siedlerchr Siedlerchr deleted the fix-dir-for-latex-citations branch November 5, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LaTeX citations: LaTeX file directory should default to the path of the library
3 participants