-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close the tab that the cursor is on when right-clicking and selecting close #8193
Conversation
This unit test |
@HoussemNasri Oh thanks, probably forgotten to add it with the |
My fork doesn't contain those changes, should I update it? |
You can directly fix that in this pr |
Can you elaborate more |
Add: jabref/src/test/java/org/jabref/logic/importer/fetcher/CompositeIdFetcherTest.java Lines 28 to 29 in 2153a05
See also the other fetch test classes. The annotation is used to categorize and excklude the fetcher tests from the normal Test workflow as they will often fail due to rate limits when they are run everytime. |
Ah okay, no, you should be able to do a git merge upstream/master into your branch. That should not create any conflicts (except for Changelog maybe) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my perspective the fixes look good, and I guess @koppor will be happy :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
Fixes #8180
The fix works for bothRight-Click > Close
andRight-Click > Close others
This fixes the whole context menu but now the PR title is misleading, I couldn't come up with a good one, if you have a better one, please edit it
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)