Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed two unused preference options #8164

Merged
merged 2 commits into from
Oct 18, 2021
Merged

Removed two unused preference options #8164

merged 2 commits into from
Oct 18, 2021

Conversation

calixtus
Copy link
Member

Refs #8148 (comment)

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor merged commit b844703 into main Oct 18, 2021
@koppor koppor deleted the remove-unused-prefs branch October 18, 2021 19:26
@calixtus calixtus added preferences status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers code-quality type: code-quality Issues related to code or architecture decisions and removed code-quality labels Oct 18, 2021
@calixtus calixtus mentioned this pull request Oct 18, 2021
Merged
5 tasks
Siedlerchr added a commit that referenced this pull request Oct 22, 2021
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into disableColumnFitToW…
374f8ba 
…idth

* upstream/main:
  Fix some typos (#8157)
  Removed two unused preference options (#8164)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@koppor koppor koppor approved these changes

Assignees
No one assigned
Labels
preferences status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers type: code-quality Issues related to code or architecture decisions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixtus @Siedlerchr @koppor