-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tests to DoiCleanup #8124
Add Tests to DoiCleanup #8124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on tests. Since this also seems to be a coding exercise, some code feedbacks:
Besides small comments, I would suggest to convert all tests checking to a ParameterizedTest
. See org.jabref.logic.bst.BibtexCaseChangersTest#testChangeCaseAllLowers for an example. Can be written even more simple in your case --> first paramter the expected entry, the second one the BibEntry to cleanup.
Thanks for the feedback and tips. I took your sugestion and changed to |
* upstream/main: (149 commits) Add Tutorials for javafx lint Add changelot Open folder on mac and highlight file Add Tests to DoiCleanup (#8124) Improve Drag and Drop in Custom Entry types dialog (#8121) Show preview also for available styles (#8110) udpate to javafx 17.0.0.1 Don't throw exception when validating invalid paths (#8112) Bump jackson-dataformat-yaml from 2.12.5 to 2.13.0 Bump jackson-datatype-jsr310 from 2.12.5 to 2.13.0 Bump byte-buddy-parent from 1.11.15 to 1.11.18 Bump classgraph from 4.8.116 to 4.8.121 Bump checkstyle from 9.0 to 9.0.1 remove iso charset, website returns utf8 for icar comp sci only returns one result fix springer fetcher Fix computer science fetcher Squashed 'buildres/csl/csl-locales/' changes from 7a507fc008..495f888637 Squashed 'buildres/csl/csl-styles/' changes from 5facb37..3b00357 Update CHANGELOG.md snap: Use lzo compression & switch to core20 base ...
Adding unit tests to DoiCleanup class, to improve the coverage of the project.
I added 7 test to the file:
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)