Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement more pdf importers #7947

Merged
merged 51 commits into from
Aug 18, 2021
Merged

Implement more pdf importers #7947

merged 51 commits into from
Aug 18, 2021

Commits on Jul 30, 2021

  1. GrobidPdfMetadataImporter implemented 

    Implemented an Importer that querries Grobid for metadata of a pdf.
The necessary Grobid functionality (retrieving BibTeX for a pdf) is not yet
available in Grobid, but we opened a PR that implements it
(kermitt2/grobid#800).
    @btut
    btut committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    8a7b80f View commit details
    Browse the repository at this point in the history

  2. Fixed class when accessing resources

    @btut
    btut committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    6fe2a23 View commit details
    Browse the repository at this point in the history

  3. Use FileHelper method to get extension

    @btut
    btut committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    f99bc52 View commit details
    Browse the repository at this point in the history

  4. Use jsoup to issue POST request

    @btut
    btut committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    1d64d80 View commit details
    Browse the repository at this point in the history

  5. Removed unnecessary field

    @btut
    btut committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    f591bfc View commit details
    Browse the repository at this point in the history

  6. Reverted URLDownload 

    It's no longer necessary to set the POST data by bytes as we use JSoup
for that.
    @btut
    btut committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    b2bd365 View commit details
    Browse the repository at this point in the history

  7. Changelog entry

    @btut
    btut committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    e458c77 View commit details
    Browse the repository at this point in the history

  8. Add pdf link to imported entry

    @btut
    btut committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    5478585 View commit details
    Browse the repository at this point in the history

  9. Remove citationkey from Grobid 

    Grobid cannot predict a citationkey
    @btut
    btut committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    d0cc663 View commit details
    Browse the repository at this point in the history

  10. FirstPageImporter

    @btut
    btut committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    2cd78fc View commit details
    Browse the repository at this point in the history

  11. Fixed grammar mistake in CHANGELOG.md 

    Co-authored-by: Christoph <[email protected]>
    @btut @Siedlerchr
    btut and Siedlerchr authored Jul 30, 2021
    Configuration menu
    Copy the full SHA
    eb22157 View commit details
    Browse the repository at this point in the history

  12. Fixed Grobid tests

    @btut
    btut committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    3ac0094 View commit details
    Browse the repository at this point in the history

  13. Fixed Grobid URL

    @btut
    btut committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    c87ed4e View commit details
    Browse the repository at this point in the history

  14. Checkstyle

    @btut
    btut committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    3d8c4da View commit details
    Browse the repository at this point in the history

  15. Fixed doc

    @btut
    btut committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    168b866 View commit details
    Browse the repository at this point in the history

  16. Checkstyle

    @btut
    btut committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    42adea9 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2021

  1. Use JSoup for plaintext citations as well

    @btut
    btut committed Aug 1, 2021
    Configuration menu
    Copy the full SHA
    73dc505 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2021

  1. Renamed FirstPageImporter to PdfVerbatimBibTextImporter

    @btut
    btut committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    7ce7105 View commit details
    Browse the repository at this point in the history

  2. Fixed getName (no importer)

    @btut
    btut committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    53d8e9a View commit details
    Browse the repository at this point in the history

  3. Renamed Grobid importer to match convention

    @btut
    btut committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    9080f14 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2021

  1. PdfEmbeddedBibTeXImporter

    @btut
    btut committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    2757be6 View commit details
    Browse the repository at this point in the history

  2. Renamed PdfEmbeddedBibTeXImporter to PdfEmbeddedBibFileImporter

    @btut
    btut committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    8a05c3e View commit details
    Browse the repository at this point in the history

  3. Checkstyle

    @btut
    btut committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    0c488ec View commit details
    Browse the repository at this point in the history

  4. Remove debug output

    @btut
    btut committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    02057f0 View commit details
    Browse the repository at this point in the history

  5. Checkstyle

    @btut
    btut committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    3d66855 View commit details
    Browse the repository at this point in the history

  6. PdfMergeMetadataImporter

    @btut
    btut committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    fd8918b View commit details
    Browse the repository at this point in the history

  7. Add DOI and ISBN fetching in PdfMergeMetadataImporter

    @btut
    btut committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    56868f5 View commit details
    Browse the repository at this point in the history

  8. Fixed concurrent list access

    @btut
    btut committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    479a0bc View commit details
    Browse the repository at this point in the history

  9. Adapted tests to contain fetchable ID's

    @btut
    btut committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    cb6a910 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2021

  1. Merge branch 'main' of github.com:JabRef/jabref into improvement/more… 

    …PdfImporters
    @btut
    btut committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    e18eabd View commit details
    Browse the repository at this point in the history

  2. Derive XMP preferences from importFormatPreferences

    @btut
    btut committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    1bf6409 View commit details
    Browse the repository at this point in the history

  3. Localization

    @btut
    btut committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    787e040 View commit details
    Browse the repository at this point in the history

  4. Use Importers in JabRef

    @btut
    btut committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    a3cdff9 View commit details
    Browse the repository at this point in the history

  5. Remove unnecessary test documents

    @btut
    btut committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    564988a View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2021

  1. Checkstyle

    @btut
    btut committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    e3d279a View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2021

  1. Grobid Timeout

    @btut
    btut committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    04eecaf View commit details
    Browse the repository at this point in the history

  2. Null-check

    @btut
    btut committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    b7e5b62 View commit details
    Browse the repository at this point in the history

  3. Use MergeImporter as WebFetcher 

    Users can perform a PDF import on already imported pdf's to improve the
quality of the entry
    @btut
    btut committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    5cbf919 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2021

  1. Only force BibTeX import if everything else fails 

    Fixes JabRef#7984
    @btut
    btut committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    1cb4dfc View commit details
    Browse the repository at this point in the history

  2. Prioritize non-bruteforce importers that 

    When importing, try importers that can tell if they are suitable for a
certain file format or not.
Some importers only check if a file is present, not if it in the correct
format (isRecognizedFormat is always true if an existing file is given).
They are used last.

The List of importers now reflects that prioritization. It is not sorted
by importer names anymore.
The getter-methods getImportFormats and getImportFormatList still sort
the List by name for the View.
    @btut
    btut committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    3ab8ebb View commit details
    Browse the repository at this point in the history

  3. Checkstyle

    @btut
    btut committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    7ba8b40 View commit details
    Browse the repository at this point in the history

  4. Fixed WebFetchersTest

    @btut
    btut committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    18dbb67 View commit details
    Browse the repository at this point in the history

  5. Grobid does not need localization

    @btut
    btut committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    3d46df4 View commit details
    Browse the repository at this point in the history

  6. Followup on removed Grobid localization

    @btut
    btut committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    40b2759 View commit details
    Browse the repository at this point in the history

  7. Fixed tests

    @btut
    btut committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    6324cf2 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' of github.com:JabRef/jabref into improvement/more… 

    …PdfImporters
    @btut
    btut committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    5cf2af7 View commit details
    Browse the repository at this point in the history

  9. Checkstyle

    @btut
    btut committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    b555ada View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2021

  1. Merge branch 'main' of github.com:JabRef/jabref into improvement/more… 

    …PdfImporters
    @btut
    btut committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    a7604b6 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2021

  1. Grobid Fetcher and Tests adapted to updated Grobid

    @btut
    btut committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    4cff87c View commit details
    Browse the repository at this point in the history

  2. Adapted GrobidServiceTest to updated Grobid

    @btut
    btut committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    4ac2002 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of github.com:JabRef/jabref into improvement/more… 

    …PdfImporters
    @btut
    btut committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    43e22b7 View commit details
    Browse the repository at this point in the history