Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements on JournalsTab in the preferences #7937

Merged
merged 13 commits into from
Jul 30, 2021

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented Jul 24, 2021

Most of it are some simple changes to the JournalsTab to improve consistency in the UI.
Removed also the single new empty pseudoabbreviation, since it produced some bugs and I did not see a benefit (correct me if I'm wrong)

Before:

image
image

After:

grafik
image

Someday JournalTabViewModel really should be refactored.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@calixtus calixtus added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jul 24, 2021
@calixtus calixtus changed the title Visual improvements on JournalsTab in the preferences Various improvements on JournalsTab in the preferences Jul 28, 2021
@Siedlerchr Siedlerchr merged commit 399e117 into main Jul 30, 2021
@Siedlerchr Siedlerchr deleted the cleanup-journalstab branch July 30, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants