Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #4652: Add Find Unlinked Files Filter based on Date #7846

Merged
merged 67 commits into from
Jun 28, 2021
Merged

Fix for issue #4652: Add Find Unlinked Files Filter based on Date #7846

merged 67 commits into from
Jun 28, 2021

Commits on May 5, 2021

  1. Display last edited date along with filename 

    Change getDisplayText to display the last edited time
    @gliargovas
    gliargovas committed May 5, 2021
    Configuration menu
    Copy the full SHA
    afd9ba6 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2021

  1. Create DateRange object 

    The DateRange enum contains the different date range names to be displayed on the newly created "select by date" filter on the unlinked files dialog window.
    @gliargovas
    gliargovas committed Jun 13, 2021
    Configuration menu
    Copy the full SHA
    3d5c737 View commit details
    Browse the repository at this point in the history

  2. Add ExternalFilesDateViewModel 

    Create the ViewModel object for the ExternalFilesDate field that will be an applicable search filter for external files.
    @gliargovas
    gliargovas committed Jun 13, 2021
    Configuration menu
    Copy the full SHA
    318e79d View commit details
    Browse the repository at this point in the history

  3. Add getDisplayTextWithEditDate method 

    The method has similar functionality to getDisplayText with the difference that it also returns the last edited date of a file to be displayed.
    @gliargovas
    gliargovas committed Jun 13, 2021
    Configuration menu
    Copy the full SHA
    59d5bfd View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2021

  1. Create File Date Combobox

    @gdrosos
    gdrosos committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    aed71d4 View commit details
    Browse the repository at this point in the history

  2. Fix typo

    @gdrosos
    gdrosos committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    be11dab View commit details
    Browse the repository at this point in the history

  3. Add Functionality of FileDateCombo box

    @gdrosos
    gdrosos committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    3b9d286 View commit details
    Browse the repository at this point in the history

  4. Add ViewModel Functionality for the Last Edited Filter

    @gdrosos
    gdrosos committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    3f7aa41 View commit details
    Browse the repository at this point in the history

  5. Modify Unlinked Files Crawler to support Last Edited Filter

    @gdrosos
    gdrosos committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    cb303c5 View commit details
    Browse the repository at this point in the history

  6. Add FileFilterUtils.java 

    The file contains the implementation of the functionality for filtering the unlinked files by specified filters.
    @gliargovas
    gliargovas committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    04962f0 View commit details
    Browse the repository at this point in the history

  7. Add "Last Edited:" to l10n package

    @gliargovas
    gliargovas committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    c6625bf View commit details
    Browse the repository at this point in the history

  8. add External File Sorter Class

    @gdrosos
    gdrosos committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    ec54bc3 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2021

  1. Add FileSortViewModel 

    Create the view model representing a selected sort-by method.
    @gliargovas
    gliargovas committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    c099ce0 View commit details
    Browse the repository at this point in the history

  2. Add Sort by combo box

    @gliargovas
    gliargovas committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    e6e15d5 View commit details
    Browse the repository at this point in the history

  3. Add fileSortCombo view side code

    @gliargovas
    gliargovas committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    1e9ec13 View commit details
    Browse the repository at this point in the history

  4. Add sort by date functionality methods 

    Add the methods for sorting the unlinked local files based on last
edited date.
    @gliargovas
    gliargovas committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    639aa8e View commit details
    Browse the repository at this point in the history

  5. Add View Model implementation for sort by date field

    @gdrosos
    gdrosos committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    291d645 View commit details
    Browse the repository at this point in the history

  6. Add Sort Support to Crawler

    @gdrosos
    gdrosos committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    ba7116e View commit details
    Browse the repository at this point in the history

  7. Rename filteredFiles variable in Crawler

    @gdrosos
    gdrosos committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    87c0111 View commit details
    Browse the repository at this point in the history

  8. Add "Sort by:" to en localiztion properties

    @gliargovas
    gliargovas committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    7cc1c50 View commit details
    Browse the repository at this point in the history

  9. Fix syntax error 

    Import java.util.List that was used, but not imported.
    @gliargovas
    gliargovas committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    4b3038e View commit details
    Browse the repository at this point in the history

  10. Fix typo in File Filter Utils

    @gdrosos
    gdrosos committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    7a53d2e View commit details
    Browse the repository at this point in the history

  11. Fix incorrect reverse sorting method call

    @gliargovas
    gliargovas committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    18b6df6 View commit details
    Browse the repository at this point in the history

  12. Convert days to months in isDuringLastMonth method

    @gdrosos
    gdrosos committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    757a8a7 View commit details
    Browse the repository at this point in the history

  13. Add Unit Tests for isDuring methods in FileFilterUtils

    @gdrosos
    gdrosos committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    22aef66 View commit details
    Browse the repository at this point in the history

  14. Improve code quality of FileFilterUtilsTest

    @gdrosos
    gdrosos committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    f49a0ae View commit details
    Browse the repository at this point in the history

  15. make variables of FileFilterUtilsTest final

    @gdrosos
    gdrosos committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    07d5174 View commit details
    Browse the repository at this point in the history

  16. Leave new line to all files

    @gdrosos
    gdrosos committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    6791053 View commit details
    Browse the repository at this point in the history

  17. Update Changelog

    @gdrosos
    gdrosos committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    02017c3 View commit details
    Browse the repository at this point in the history

  18. Merge branch 'main' into fix-for-issue-4652

    @gdrosos
    gdrosos authored Jun 22, 2021
    Configuration menu
    Copy the full SHA
    7fcfff6 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2021

  1. Improve code quality according to Codacy Code Analysis

    @gdrosos
    gdrosos committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    91235b4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'fix-for-issue-4652' of https://github.com/gdrosos/jabref … 

    …into fix-for-issue-4652
    @gdrosos
    gdrosos committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    e191344 View commit details
    Browse the repository at this point in the history

  3. Further improve code quality according to Codacy Code Analysis

    @gdrosos
    gdrosos committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    076f1db View commit details
    Browse the repository at this point in the history

  4. Minor Code quality improvement

    @gdrosos
    gdrosos committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    1e6cca7 View commit details
    Browse the repository at this point in the history

  5. Fix Typo

    @gdrosos
    gdrosos committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    66db608 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2021

  1. Use Logger to log exceptions

    @gdrosos
    gdrosos committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    0998abd View commit details
    Browse the repository at this point in the history

  2. Use method reference operator 

    Use  method reference operator instead of lambda

Co-authored-by: Christoph <[email protected]>
    @gdrosos @Siedlerchr
    gdrosos and Siedlerchr authored Jun 25, 2021
    Configuration menu
    Copy the full SHA
    fde0180 View commit details
    Browse the repository at this point in the history

  3. Use localization to show localized strings

    @gdrosos
    gdrosos committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    7d83221 View commit details
    Browse the repository at this point in the history

  4. Apply suggested changes from Codacy

    George Liargkovas committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    87d6b9f View commit details
    Browse the repository at this point in the history

  5. Revert "Use method reference operator " 

    This reverts commit fde0180.
    @gdrosos
    gdrosos committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    aad00fc View commit details
    Browse the repository at this point in the history

  6. Add unlinked files filter fields localisation

    @gliargovas
    gliargovas committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    998d52d View commit details
    Browse the repository at this point in the history

  7. Merge branch 'fix-for-issue-4652' of https://github.com/gdrosos/jabref … 

    …into fix-for-issue-4652
    @gliargovas
    gliargovas committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    6a02336 View commit details
    Browse the repository at this point in the history

  8. Fix typo

    @gliargovas
    gliargovas committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    425c258 View commit details
    Browse the repository at this point in the history

  9. Use meaningful names in lambda expressions

    @gliargovas
    gliargovas committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    482212d View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2021

  1. Refactor code to use DateRange enum instead of strings

    @gliargovas
    gliargovas committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    234943a View commit details
    Browse the repository at this point in the history

  2. Remove wrongly commited code

    @gliargovas
    gliargovas committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    4f812a9 View commit details
    Browse the repository at this point in the history

  3. Use ExternalFileSorter Enums instead of Strings

    @gdrosos
    gdrosos committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    e949db9 View commit details
    Browse the repository at this point in the history

  4. Ensure the code passes LocalizationConsistencyTests 

    Add to the JabRef_en.properties two language keys and remove a duplicate one. Now all Unit tests should pass
    @gdrosos
    gdrosos committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    7295535 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2021

  1. Add tests for FileFilterUtils sort methods

    @gliargovas
    gliargovas committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    9b001f6 View commit details
    Browse the repository at this point in the history

  2. Fix code format issues

    @gliargovas
    gliargovas committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    ccd8e92 View commit details
    Browse the repository at this point in the history

  3. Update FileFilterUtilsTests with minor fixes

    @gdrosos
    gdrosos committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    c2c7ae6 View commit details
    Browse the repository at this point in the history

  4. Add negative sort tests and improve code format

    @gliargovas
    gliargovas committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    bd9dbf7 View commit details
    Browse the repository at this point in the history

  5. Use Path.of() instead of Paths.get()

    @gliargovas
    gliargovas committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    1a58342 View commit details
    Browse the repository at this point in the history

  6. Fix FileFilterUtilsTest code format

    @gliargovas
    gliargovas committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    08f0f19 View commit details
    Browse the repository at this point in the history

  7. Add documentation to UnlinkedFilesCrawler and FileFilterUtils

    @gliargovas
    gliargovas committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    4db03ee View commit details
    Browse the repository at this point in the history

  8. Add comment descriptions to FileFilterUtilsTest

    @gliargovas
    gliargovas committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    3825ee9 View commit details
    Browse the repository at this point in the history

  9. Replace minusMonths() and minusYears() with minusDays()

    @gliargovas
    gliargovas committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    7762cb9 View commit details
    Browse the repository at this point in the history

  10. Use TempDir at Unit Tests

    @gdrosos
    gdrosos committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    6e721c5 View commit details
    Browse the repository at this point in the history

  11. Remove the use of java.io.File

    @gliargovas
    gliargovas committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    a495c16 View commit details
    Browse the repository at this point in the history

  12. Use streams for sort tests 

    * Use streams instead of creating new arrays.
* Use assertEquals and assertNotEquals instead of assertArrayEquals and
assertFalse.
    @gliargovas
    gliargovas committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    a6f91c0 View commit details
    Browse the repository at this point in the history

  13. Remove unused imports

    @gliargovas
    gliargovas committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    5136b1f View commit details
    Browse the repository at this point in the history

  14. Use enums directly for filter and sort fields

    @gliargovas
    gliargovas committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    0b459a6 View commit details
    Browse the repository at this point in the history

  15. Remove redundant default cases from FileFilterUtils.java

    @gliargovas
    gliargovas committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    226010b View commit details
    Browse the repository at this point in the history

  16. replace DateRange enums with values() method 

    Co-authored-by: Carl Christian Snethlage <[email protected]>
    @gdrosos @calixtus
    gdrosos and calixtus authored Jun 27, 2021
    Configuration menu
    Copy the full SHA
    1e2f8c4 View commit details
    Browse the repository at this point in the history

  17. Replace ExternalFileSorter enums with values() method in UnlinkedFile… 

    …sDialogViewModel

Co-authored-by: Carl Christian Snethlage <[email protected]>
    @gdrosos @calixtus
    gdrosos and calixtus authored Jun 27, 2021
    Configuration menu
    Copy the full SHA
    3334398 View commit details
    Browse the repository at this point in the history

  18. Place the correct order in DateTime enums

    @gdrosos
    gdrosos committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    4ae48a1 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2021

  1. Make sure a value is returned when an IOException occurs in getFileTi… 

    …me() method
    @gdrosos
    gdrosos committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    4a00080 View commit details
    Browse the repository at this point in the history