Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 5522 and some UI changes. #7547

Merged
merged 3 commits into from
Mar 17, 2021

Conversation

mohit038-zz
Copy link
Contributor

Fixes #5522

  1. Adding patterns to the entries background in dark theme.

Screenshot 2021-03-16 at 8 39 32 PM

  1. Visibility issue with the group item number coloration when an item is assigned to a new group as mentioned in Dark theme: Visibility problems with current colouring scheme (group colouring and scroll bars) #5522 (comment)

Screenshot 2021-03-16 at 8 52 01 PM

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@@ -66,6 +66,22 @@
-fx-background-color: -fx-control-inner-background;
}

.table-row-cell: odd{
-fx-background-color:#272b38 ;
-fx-background-insets: 0, 0 0 1 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the insets and padding don't need to be set here again, as they are controlled by the light theme, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right. I'll change it.

Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 17, 2021
@Siedlerchr
Copy link
Member

Thanks a lot for your contribution!

@Siedlerchr Siedlerchr merged commit d190268 into JabRef:master Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark theme: Visibility problems with current colouring scheme (group colouring and scroll bars)
4 participants