Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix: Fix compilation error #7514

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Hotfix: Fix compilation error #7514

merged 2 commits into from
Mar 11, 2021

Conversation

koppor
Copy link
Member

@koppor koppor commented Mar 11, 2021

The SNAPSHOT version of citeproc-java changed the constructor. Thus, JabRef did not compile when fetching the latest SNAPSHOT from maven central.

This PR fixes the constructor.

It also changed build.gradle to trigger a refetch of all dependencies in our CI.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@koppor
Copy link
Member Author

koppor commented Mar 11, 2021

The upstream commit is michel-kraemer/citeproc-java@fbf8e3d#diff-5452061a6ee2b7bff8b3a4f2a58229865d77fb80fc013dee32411c0280dc95f2.

@koppor koppor mentioned this pull request Mar 11, 2021
Closed
@koppor koppor requested a review from Siedlerchr March 11, 2021 12:41
@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 11, 2021
@Siedlerchr Siedlerchr merged commit 249a73c into master Mar 11, 2021
@Siedlerchr Siedlerchr deleted the fix-csl branch March 11, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koppor @Siedlerchr