-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unuseful search syntax feedback #7391
Conversation
I'm against removing the syntax check. From a user perspective, you want to be notified as early as possible that your search query is not valid and not only after you click the search button. Moreover, showing the query syntax problem as some kind of overlay is nicer than a modal error dialog. That being said, the user experience can indeed be improved. For example, I'm a fan of a more visual representation of the search query as for example in https://dribbble.com/shots/6323387-Job-Search or http://evoluteur.github.io/structured-filter/index.html |
Nice! Then I would prefer to remove the check in the same PR that also converts to the chip-based design (or in two PRs that are merged directly after each other). Or is the check currently so broken that the fetchers are not useable? |
The issues are:
I believe we can re-add the feedback before a new release (#7411). Assigned the issue to the next milestone. |
I think it is unreasonable to remove the syntax check. |
@Fu188 Please not my comment above:
Only users using a non-released version will have no syntax checks. We will work on #7411. This will be possible with our new query syntax, which will be translated to the fetchers. Currently, the user has to know the differences between IEEE, ACM, arXiv and modify the query when changing the fetcher. With the new infrastructure, JabRef will do the translation for you. |
This PR removes unuseful feedback from the web search text field, as it is not necessary and provides no advantage.
With the introduction of transformers in #7350, the syntax feedback will be adapted and provide adequate and useful feedback.
Fixes #7349, addresses #7277.