Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snapcraft upload #7263

Merged
merged 2 commits into from
Jan 10, 2021
Merged

Fix snapcraft upload #7263

merged 2 commits into from
Jan 10, 2021

Conversation

koppor
Copy link
Member

@koppor koppor commented Dec 28, 2020

This PR tries to fix upload to snapcraft.

Before this PR:

Run snapcore/action-publish@v1
  with:
    store_login: ***
    snap: jabref_5.2.376_amd64.snap
    release: edge
Publishing snap "jabref_5.2.376_amd64.snap"...
/snap/bin/snapcraft login --with /tmp/login-data-37F4mR/login.txt
Unexpected error when obtaining your account information.
Login failed.
Error: The process '/snap/bin/snapcraft' failed with exit code 1

See https://github.com/JabRef/jabref/runs/1605853743

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@koppor koppor marked this pull request as draft December 28, 2020 17:44
@Siedlerchr
Copy link
Member

@LyzardKing The snap seems to throw an error:

 The store was unable to accept this snap.
  - human review required due to 'allow-installation' constraint (interface attributes)
  - interface reference 'etc-opt-edge-native-messaging-jabref' not allowed. Please use one of: hostfs-mozilla-native-messaging-jabref, etc-opt-chrome-native-messaging-jabref, etc-chromium-native-messaging-jabref

@koppor
Copy link
Member Author

koppor commented Dec 28, 2020

Our SnapCraft build seems to have not worked since 2 months (think, it is related to #7056).

Now, I have following two reports:

  • human review required due to 'allow-installation' constraint (interface attributes)
  • interface reference 'etc-opt-edge-native-messaging-jabref' not allowed. Please use one of: hostfs-mozilla-native-messaging-jabref, etc-opt-chrome-native-messaging-jabref, etc-chromium-native-messaging-jabref

I will request the human review because of etc-opt-edge-native-messaging-jabref. I ask for it at https://forum.snapcraft.io/t/system-files-under-mozilla-native-messaging-hosts/13627/42?u=koppor.

@Siedlerchr Siedlerchr added the status: depends-on-external A bug or issue that depends on an update of an external library label Jan 1, 2021
@Siedlerchr
Copy link
Member

I merge this, should not influence our waiting for manual review

@Siedlerchr Siedlerchr marked this pull request as ready for review January 8, 2021 17:47
@Siedlerchr Siedlerchr merged commit 0a971fd into master Jan 10, 2021
@Siedlerchr Siedlerchr deleted the snapcraft branch January 10, 2021 19:15
Siedlerchr added a commit that referenced this pull request Jan 13, 2021
…dtask

* upstream/master:
  Update guidelines-for-setting-up-a-local-workspace.md (#7339)
  Updates to colored group indicator for cited entries (#7173)
  Add some special fields as default columns (#7286)
  Add a more descriptive path when Directory cannot be found (#7232)
  Bump antlr4 from 4.9 to 4.9.1 (#7327)
  Bump unirest-java from 3.11.09 to 3.11.10 (#7329)
  Bump mockito-core from 3.6.28 to 3.7.0 (#7328)
  Bump antlr4-runtime from 4.9 to 4.9.1 (#7330)
  Bump gittools/actions from v0.9.7 to v0.9.8 (#7331)
  Update to gradle 6.8 (#7324)
  Link to GitHub contributors in about dialog (#7319)
  Fix snapcraft upload (#7263)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: depends-on-external A bug or issue that depends on an update of an external library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants