Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable SLR in UI until #7126 is merged #7179

Merged
merged 1 commit into from
Dec 12, 2020
Merged

Disable SLR in UI until #7126 is merged #7179

merged 1 commit into from
Dec 12, 2020

Conversation

DominikVoigt
Copy link
Contributor

@DominikVoigt DominikVoigt commented Dec 12, 2020 •
edited
Loading

This PR addresses the issue of integrating the SLR feature in the planned release version without #7126 by disabling it.
Refs #7168

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

calixtus
calixtus approved these changes Dec 12, 2020
View reviewed changes
Copy link
Member

@calixtus calixtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly approved...

@tobiasdiez tobiasdiez merged commit 86e2c82 into master Dec 12, 2020
@tobiasdiez tobiasdiez deleted the disable-slr branch December 12, 2020 22:02
Siedlerchr added a commit that referenced this pull request Dec 13, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into sharedDbInsert
c6d01b3 
* upstream/master:
  Disable SLR in UI until #7126 is merged (#7179)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixtus calixtus calixtus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DominikVoigt @calixtus @tobiasdiez