-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add restart warning for auto complete settings #6564
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
package org.jabref.gui.preference; | ||
|
||
|
||
import org.jabref.gui.autocompleter.AutoCompleteFirstNameMode; | ||
import org.jabref.gui.autocompleter.AutoCompletePreferences; | ||
import org.jabref.model.entry.field.FieldFactory; | ||
import org.jabref.preferences.JabRefPreferences; | ||
import org.junit.Test; | ||
|
||
import java.lang.reflect.Field; | ||
|
||
import static org.junit.Assert.assertEquals; | ||
|
||
|
||
public class SaveAutoCompleteTest { | ||
|
||
@Test | ||
public void storeAutoCompletePreferencesTest() throws NoSuchFieldException, IllegalAccessException { | ||
JabRefPreferences preferencesService = JabRefPreferences.getInstance(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. While testing is normally important, I fear in this case you actually permanently set the preferences to true instead of testing the logic. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The test actually does not make any sense. You are just testing that a boolean variable is set in the preferences. This is useless and totally unrelated to your changes. Manual testing should be enough. In jabref we focus on writing tests for important logic or other parts and not just writing tests for the sake of coverage. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, you are right. That test makes no sense for this issue. This was my early attempt while locating the code. It is really kind for you to point it out as well as two typos. Thanks. And I am still learning Github and its features. |
||
preferencesService.storeAutoCompletePreferences(new AutoCompletePreferences( | ||
true, | ||
AutoCompleteFirstNameMode.BOTH, | ||
AutoCompletePreferences.NameFormat.BOTH, | ||
FieldFactory.parseFieldList(""), | ||
preferencesService.getJournalAbbreviationPreferences())); | ||
|
||
Field field = preferencesService.getClass().getDeclaredField("AUTO_COMPLETE"); | ||
field.setAccessible(true); | ||
assertEquals(preferencesService.getBoolean((String) field.get(preferencesService)), true); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have a lot of checkstyle issues here. Please setup the JabRef Code Style and make your life easier
https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace#using-jabrefs-code-style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your review.