Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes generated bibtex key and display of institute authors #6479

Merged
merged 65 commits into from
May 28, 2020

Commits on May 13, 2020

  1. Configuration menu
    Copy the full SHA
    fd405cf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a6354e3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    149ed4f View commit details
    Browse the repository at this point in the history
  4. Fix invalid index in call to substring

    The original condition is evaluated to false.
    The substring is shorter than "uni".
    k3KAW8Pnf7mkmdSMPHz27 committed May 13, 2020
    Configuration menu
    Copy the full SHA
    b57f1b2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fae093b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5a23a9a View commit details
    Browse the repository at this point in the history
  7. Fix check for uppercase letter

    Perhaps the assumption should be that the letters are ASCII.
    If all letters are ASCII checking 'A' <= k.charAt(0) <= 'Z'
    might make more sense.
    I am not convinced about doing this with a regex.
    k3KAW8Pnf7mkmdSMPHz27 committed May 13, 2020
    Configuration menu
    Copy the full SHA
    6af8c7e View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    716f885 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    cdfd56a View commit details
    Browse the repository at this point in the history
  10. Add test cases

    Both test cases involves an author name containing department or school
     without university or institute of technology.
    k3KAW8Pnf7mkmdSMPHz27 committed May 13, 2020
    Configuration menu
    Copy the full SHA
    b227edb View commit details
    Browse the repository at this point in the history
  11. Fix null appearing as part of author name

    Corporate authors without university/institute of technology
    k3KAW8Pnf7mkmdSMPHz27 committed May 13, 2020
    Configuration menu
    Copy the full SHA
    ef7f979 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2020

  1. Configuration menu
    Copy the full SHA
    9ac3993 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2020

  1. Merge branch 'master' into fix-for-issue-6459

    # Conflicts:
    #	src/main/java/org/jabref/logic/bibtexkeypattern/BracketedPattern.java
    k3KAW8Pnf7mkmdSMPHz27 committed May 15, 2020
    Configuration menu
    Copy the full SHA
    85c96ce View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6ded410 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2020

  1. Configuration menu
    Copy the full SHA
    e8c3007 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    72eb1fe View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2eee8dd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cc54029 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2020

  1. Configuration menu
    Copy the full SHA
    1063ae1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ef94758 View commit details
    Browse the repository at this point in the history
  3. Fix key for institution's name containing keyword

    If the name of an institution can't be split, assume that
    "School"/"Department" is part of the name.
    k3KAW8Pnf7mkmdSMPHz27 committed May 19, 2020
    Configuration menu
    Copy the full SHA
    e80bd8b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a0ed455 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4db0824 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    383fc14 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c3e5f09 View commit details
    Browse the repository at this point in the history
  8. Fix JavaDoc

    Minor typos and the "rest" part is now created differently.
    k3KAW8Pnf7mkmdSMPHz27 committed May 19, 2020
    Configuration menu
    Copy the full SHA
    5990c2a View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    0df3cdb View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    f0d9601 View commit details
    Browse the repository at this point in the history
  11. Drop logger

    k3KAW8Pnf7mkmdSMPHz27 committed May 19, 2020
    Configuration menu
    Copy the full SHA
    6f26a73 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2020

  1. Configuration menu
    Copy the full SHA
    9b717c5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5ed9c54 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d6e9e70 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2dc664d View commit details
    Browse the repository at this point in the history
  5. Fix to only keep the first character of each word

    There are some examples that will turn out wrong if only capital letters
     are kept, e.g., "iOS Developer University Program".
     The original problem with "The School of Life" becoming too short is
     avoided by only removing school/department for names containing two or
      more ',' separated strings. This will still produce an unexpected
       result if the address of the institution is part of the authors field
    k3KAW8Pnf7mkmdSMPHz27 committed May 20, 2020
    Configuration menu
    Copy the full SHA
    f0fd4f1 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2020

  1. Configuration menu
    Copy the full SHA
    feebf81 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d4c2ce3 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2020

  1. Configuration menu
    Copy the full SHA
    04abe5e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3f3ef62 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f4fbec1 View commit details
    Browse the repository at this point in the history
  4. Add test for latex-free comma separated first name

    First name first and abbreviated first name first
    k3KAW8Pnf7mkmdSMPHz27 committed May 22, 2020
    Configuration menu
    Copy the full SHA
    a256fa8 View commit details
    Browse the repository at this point in the history
  5. Add test for latex-free comma separated last name

    Last name first and abbreviated first names
    k3KAW8Pnf7mkmdSMPHz27 committed May 22, 2020
    Configuration menu
    Copy the full SHA
    4961c53 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a443db0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    dd492e6 View commit details
    Browse the repository at this point in the history
  8. Fix CheckStyle issues

    The deprecated static methods BibtexKeyGenerator.generateKey are moved
    to the test file as a similar convenience method is required for
    the test cases. Suppress warning has been added for some methods.
    k3KAW8Pnf7mkmdSMPHz27 committed May 22, 2020
    Configuration menu
    Copy the full SHA
    71e45d4 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    2748dcd View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    3b0dda3 View commit details
    Browse the repository at this point in the history
  11. Fix mistake in BibtexKeyGeneratorTest

    generateKey was not copy-pasted properly.
    k3KAW8Pnf7mkmdSMPHz27 committed May 22, 2020
    Configuration menu
    Copy the full SHA
    78b66f7 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2020

  1. Configuration menu
    Copy the full SHA
    55ef8e7 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2020

  1. Configuration menu
    Copy the full SHA
    237dc35 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    78fade6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3de984d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ecac673 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1c4928b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    55f3f18 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e6cda69 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2e120fd View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    8cc947c View commit details
    Browse the repository at this point in the history

Commits on May 27, 2020

  1. Configuration menu
    Copy the full SHA
    2fc9e16 View commit details
    Browse the repository at this point in the history
  2. Refactor formatNameLatexFree

    The author list parsing is moved outside of the if/else statements
    k3KAW8Pnf7mkmdSMPHz27 committed May 27, 2020
    Configuration menu
    Copy the full SHA
    b4b3993 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3cb6232 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b3f0d1b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5a27bbc View commit details
    Browse the repository at this point in the history
  6. Refactor parse with latex tests

    Move them close to other parse tests
    k3KAW8Pnf7mkmdSMPHz27 committed May 27, 2020
    Configuration menu
    Copy the full SHA
    c7578b3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b8bf4f3 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2020

  1. Configuration menu
    Copy the full SHA
    cc23e29 View commit details
    Browse the repository at this point in the history