Fix bracket collisions #6469
Fix bracket collisions #6469
Conversation
| Boolean foundClosingBracket = false; | ||
| // make sure to read until the next ']' | ||
| while (st.hasMoreTokens()) { | ||
| String subtoken = st.nextToken(); |
There was a problem hiding this comment.
Question: you fetch the next token above in line 131, and then here the subtoken. So this moves the stream forward twice, right? What happens if the user adds an empty brace, i.e []. Is the closing bracket still found? Can you please add a test for this case as well. Thanks!
There was a problem hiding this comment.
Good catch! But what should "[]" expand to? Inside a quote, the parsing should work fine. but what does "[]" mean in terms of JabRef fields? Should it just do nothing and print an appropriate warning?
There was a problem hiding this comment.
Yes, I would say it should do nothing and log a warning. I don't really see a use case for the empty bracket, it should just not break the parser.
tobiasdiez
added
status: changes required
tobiasdiez
removed
the
status: changes required
|
Thanks again for your valuable contributions! 🥇 |
|
Glad to help and happy to have my regular expressions supported :) |
Brackets in regular expressions were interpreted as brackets for fields. This change allows users to define regular expressions that contain brackets. This led to an exception before.