Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore some missing keyboard shortcuts #6406

Merged
merged 1 commit into from
May 4, 2020
Merged

Restore some missing keyboard shortcuts #6406

merged 1 commit into from
May 4, 2020

Conversation

MootezSaaD
Copy link
Contributor

Fixes #6403

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@Siedlerchr
Copy link
Member

Thanks again for the contribution, would be cool if you could check the other keybindings as well, if there are some missing.
à simply search for reference should be the easiest way to find any missing one

tobiasdiez
tobiasdiez approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to see this stream of high-quality PRs coming from you! Keep it going 🚀

@tobiasdiez tobiasdiez merged commit e0580ed into JabRef:master May 4, 2020
Siedlerchr added a commit that referenced this pull request May 9, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master'
ded2a2a 
* upstream/master:
  Added a download checkbox to the import dialog (#6381)
  Bump jaxb-xjc from 2.3.2 to 2.3.3 (#6410)
  Bump flexmark-ext-gfm-strikethrough from 0.61.20 to 0.61.24 (#6413)
  Bump byte-buddy-parent from 1.10.9 to 1.10.10 (#6408)
  Bump flexmark-ext-gfm-tasklist from 0.61.20 to 0.61.24 (#6412)
  Bump org.beryx.jlink from 2.17.8 to 2.18.0 (#6411)
  Bump tika-core from 1.24 to 1.24.1 (#6409)
  Bump flexmark from 0.61.20 to 0.61.24 (#6416)
  Bump classgraph from 4.8.77 to 4.8.78 (#6414)
  Restore some missing keyboard shortcuts (#6406)
  Fix StartupWMClass (#6398)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@tobiasdiez tobiasdiez tobiasdiez approved these changes

Assignees
No one assigned
Labels
keybinding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some keyboard shortcuts are no longer working.
4 participants
@MootezSaaD @Siedlerchr @tobiasdiez @koppor