Entry editor: Add more tooltips and wrap tooltips if necessary #6239
Conversation
systemoperator
commented
Apr 3, 2020
•
systemoperator
commented
- Change in CHANGELOG.md described (if applicable)
- Tests created for changes (if applicable)
- Manually tested changed features in running JabRef (always required)
- Screenshots added in PR description (for bigger UI changes)
- Checked documentation: Is the information available and up to date? If not: Issue created at https://github.com/JabRef/user-documentation/issues.
|
The localization file will be updates as soon as no other changes are requested anymore. |
tobiasdiez
added
the
status: ready-for-review
|
done |
|
Hi @systemoperator, |
@calixtus Thanks for the information. That's fine. I will keep it in mind. :) |
| @@ -79,6 +109,8 @@ public String getDescription(Field field) { | |||
| case FILE: | |||
| case PDF: | |||
| return Localization.lang("Link(s) to a local PDF or other document of the work."); | |||
| case FOREWORD: | |||
| return Localization.lang("Author(s) of a foreword to the work."); | |||
There was a problem hiding this comment.
The authors are separated by and? Maybe, this can be added here?
| case JOURNALTITLE: | ||
| case JOURNAL: | ||
| return Localization.lang("Name of a journal, a newspaper, or some other periodical."); | ||
| case LABEL: | ||
| return Localization.lang("Designation to be used by the citation style as a substitute for the regular label if any data required to generate the regular label is missing."); | ||
| case LANGUAGE: | ||
| return Localization.lang("Language(s) of the work. Languages may be specified literally or as localisation keys."); |
There was a problem hiding this comment.
How are multiple languages provided?
| case KEYWORDS: | ||
| return Localization.lang("Separated list of keywords."); | ||
| case RELATED: | ||
| return Localization.lang("Citation keys of other entries which have a relationship to this entry."); |
There was a problem hiding this comment.
Do we need to add "separated by ," here?
|
@koppor we agreed the last time that the description should only clarify the semantics of the field and not the bibtex conventions (e.g "and" as separator). |
We should add an ADR here ^^. - Maybe later. I fully agree for the author thing. I have doubts about the other entries though: What would be important for me is an example for "citation keys" and "languages". The issue is that we use different separators. I really like the Java-by-Comparison approach - and they also favor examples. I would not go so far to make it as long as there:
However, a quick good example would be really helpful. That would avoid the user to change to a browser and google. Alternatively, the user is forced for a trial-and-error. |
|
@koppor for these things, we have the integrity checks right? I now merge this PR to move forward. Thanks @systemoperator for completing the descriptions! |
* upstream/master: (23 commits) Bump junit-vintage-engine from 5.6.1 to 5.6.2 (#6276) Number of items found in ImportEntriesDialog (#6248) Fix dependency label Bump flexmark-ext-gfm-strikethrough from 0.61.0 to 0.61.6 (#6273) Bump unirest-java from 3.7.01 to 3.7.02 (#6275) Bump junit-platform-launcher from 1.6.1 to 1.6.2 (#6279) Bump flexmark-ext-gfm-tasklist from 0.61.0 to 0.61.6 (#6278) Bump junit-jupiter from 5.6.1 to 5.6.2 (#6274) Bump flexmark from 0.61.0 to 0.61.6 (#6280) Bump classgraph from 4.8.68 to 4.8.69 (#6277) Bump org.beryx.jlink from 2.17.4 to 2.17.5 (#6281) Improve performance (#6270) Improve calculation of matched entries upon change (#6268) Fix sort by priority (#6222) (#6265) Squashed 'src/main/resources/csl-styles/' changes from 88726cb..db54e56 Use https everywhere Entry editor: Add more tooltips and wrap tooltips if necessary (#6239) JDK14 switch - and checkstyle skipping (#6250) Bump postgresql from 42.2.11 to 42.2.12 (#6254) Bump unirest-java from 3.7.00 to 3.7.01 (#6253) ...
* upstream/master: (287 commits) Bump junit-vintage-engine from 5.6.1 to 5.6.2 (#6276) Number of items found in ImportEntriesDialog (#6248) Fix dependency label Bump flexmark-ext-gfm-strikethrough from 0.61.0 to 0.61.6 (#6273) Bump unirest-java from 3.7.01 to 3.7.02 (#6275) Bump junit-platform-launcher from 1.6.1 to 1.6.2 (#6279) Bump flexmark-ext-gfm-tasklist from 0.61.0 to 0.61.6 (#6278) Bump junit-jupiter from 5.6.1 to 5.6.2 (#6274) Bump flexmark from 0.61.0 to 0.61.6 (#6280) Bump classgraph from 4.8.68 to 4.8.69 (#6277) Bump org.beryx.jlink from 2.17.4 to 2.17.5 (#6281) Improve performance (#6270) Improve calculation of matched entries upon change (#6268) Fix sort by priority (#6222) (#6265) Squashed 'src/main/resources/csl-styles/' changes from 88726cb..db54e56 Use https everywhere Entry editor: Add more tooltips and wrap tooltips if necessary (#6239) JDK14 switch - and checkstyle skipping (#6250) Bump postgresql from 42.2.11 to 42.2.12 (#6254) Bump unirest-java from 3.7.00 to 3.7.01 (#6253) ...
